Bug 129514 - [CSS Shapes] CSS parser accepts trailing position arguments
Summary: [CSS Shapes] CSS parser accepts trailing position arguments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bear Travis
URL:
Keywords:
Depends on:
Blocks: 124173
  Show dependency tree / graph
 
Reported: 2014-02-28 16:08 PST by Bear Travis
Modified: 2014-03-14 14:59 PDT (History)
8 users (show)

See Also:

Attachments
Initial Patch (5.91 KB, patch)
2014-03-13 12:43 PDT, Bear Travis 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bear Travis 2014-02-28 16:08:26 PST 
The shapes parsing code is accepting shapes like 'circle(at 10px 10px closest-side)', and dropping the last arguments after the position.

For example:
var el = document.createElement('div');
el.style.setProperty('-webkit-shape-outside', 'circle(at 10px 10px closest-side)');
console.log(el.style.getPropertyValue('-webkit-shape-outside'));

Logs 'circle(at 10px 10px)'
Comment 1 Bear Travis 2014-03-13 12:43:06 PDT 
Created attachment 226614 [details]
Initial Patch

Port of patch originally authored by rwlbuis here https://codereview.chromium.org/191553003/
Comment 2 WebKit Commit Bot 2014-03-14 14:59:04 PDT 
Comment on attachment 226614 [details]
Initial Patch

Clearing flags on attachment: 226614

Committed r165655: <http://trac.webkit.org/changeset/165655>
Comment 3 WebKit Commit Bot 2014-03-14 14:59:07 PDT 
All reviewed patches have been landed.  Closing bug.