Bug 129501 - [Mac, iOS] Incorrect ordering of construction arguments for out-of-band text elements
Summary: [Mac, iOS] Incorrect ordering of construction arguments for out-of-band text ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-02-28 11:52 PST by Brent Fulgham
Modified: 2014-02-28 13:07 PST (History)
11 users (show)

See Also:


Attachments
Patch (1.50 KB, patch)
2014-02-28 12:04 PST, Brent Fulgham
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-02-28 11:52:59 PST
I made a mistake in the order of arguments passed to the new "createOutOfBand" constructor for the PlatformTextTrack in HTMLMediaElement::outOfBandTrackSources. The label and source URLs were reversed.

This patch corrects that mistake so that the NSDictionary of items passed to AVFoundation is correct.
Comment 1 Radar WebKit Bug Importer 2014-02-28 11:53:32 PST
<rdar://problem/16198587>
Comment 2 Brent Fulgham 2014-02-28 12:04:19 PST
Created attachment 225479 [details]
Patch
Comment 3 Brent Fulgham 2014-02-28 13:07:25 PST
Committed r164881: <http://trac.webkit.org/changeset/164881>