Bug 129475 - Update meta-referrer behavior for invalid policies
Summary: Update meta-referrer behavior for invalid policies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-28 01:56 PST by jochen
Modified: 2014-02-28 10:04 PST (History)
7 users (show)

See Also:

Attachments
Patch (4.37 KB, patch)
2014-02-28 01:59 PST, jochen 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (478.22 KB, application/zip)
2014-02-28 03:06 PST, Build Bot 		no flags Details
Patch (4.47 KB, patch)
2014-02-28 03:10 PST, jochen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2014-02-28 01:56:00 PST 
Update meta-referrer behavior for invalid policies
Comment 1 jochen 2014-02-28 01:59:01 PST 
Created attachment 225447 [details]
Patch
Comment 2 jochen 2014-02-28 02:03:15 PST 
Alexey, can you have a look please?

The idea is that if e.g. the page author misspelled the policy (for example value="nevar"), we shouldn't silently ignore the policy, but rather revert to a safe default.
Comment 3 Build Bot 2014-02-28 03:05:57 PST 
Comment on attachment 225447 [details]
Patch

Attachment 225447 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5518799470067712

New failing tests:
http/tests/security/referrer-policy-default.html
http/tests/security/referrer-policy-https-default.html
Comment 4 Build Bot 2014-02-28 03:06:00 PST 
Created attachment 225451 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 jochen 2014-02-28 03:10:29 PST 
Created attachment 225452 [details]
Patch
Comment 6 WebKit Commit Bot 2014-02-28 10:03:58 PST 
Comment on attachment 225452 [details]
Patch

Clearing flags on attachment: 225452

Committed r164866: <http://trac.webkit.org/changeset/164866>
Comment 7 WebKit Commit Bot 2014-02-28 10:04:07 PST 
All reviewed patches have been landed.  Closing bug.