Bug 129472 - [iOS][WK2] highlight rects should never big bigger than the view
Summary: [iOS][WK2] highlight rects should never big bigger than the view
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-28 00:29 PST by Benjamin Poulain
Modified: 2014-02-28 15:50 PST (History)
1 user (show)

See Also:

Attachments
Patch (5.07 KB, patch)
2014-02-28 00:31 PST, Benjamin Poulain 		enrica: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-02-28 00:29:47 PST 
[iOS][WK2] highlight rects should never big bigger than the view
Comment 1 Benjamin Poulain 2014-02-28 00:31:04 PST 
Created attachment 225443 [details]
Patch
Comment 2 Enrica Casucci 2014-02-28 15:03:09 PST 
Comment on attachment 225443 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225443&action=review

Looks good to me.

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:296
> +static inline bool highlightedQuadsFitInRect(const Vector<FloatQuad>& quads, const FloatRect& rect)

maybe isHighlightQuadSmaller ?
Comment 3 Benjamin Poulain 2014-02-28 15:50:12 PST 
Committed r164892: <http://trac.webkit.org/changeset/164892>