Bug 129463 - Web Inspector: Use a RegExp when when using CodeMirror SearchCursor
Summary: Web Inspector: Use a RegExp when when using CodeMirror SearchCursor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-02-27 16:35 PST by Timothy Hatcher
Modified: 2014-02-27 17:13 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.84 KB, patch)
2014-02-27 16:38 PST, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2014-02-27 16:35:56 PST 
When passing a string to CodeMirror.getSearchCursor, and doing a case-insensitive search, CodeMirror will do toLowerString() on each line. That is expensive. Use a case-insensitive RegExp instead.
Comment 1 Radar WebKit Bug Importer 2014-02-27 16:36:08 PST 
<rdar://problem/16190839>
Comment 2 Timothy Hatcher 2014-02-27 16:38:50 PST 
Created attachment 225429 [details]
Patch
Comment 3 Joseph Pecoraro 2014-02-27 16:39:53 PST 
Comment on attachment 225429 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2014-02-27 17:13:24 PST 
Comment on attachment 225429 [details]
Patch

Clearing flags on attachment: 225429

Committed r164846: <http://trac.webkit.org/changeset/164846>
Comment 5 WebKit Commit Bot 2014-02-27 17:13:26 PST 
All reviewed patches have been landed.  Closing bug.