Bug 129456 - Crash in RemoteLayerTreePropertyApplier::applyPropertiesToLayer
Summary: Crash in RemoteLayerTreePropertyApplier::applyPropertiesToLayer
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
Keywords: InRadar
Depends on:
Reported: 2014-02-27 15:52 PST by Tim Horton
Modified: 2014-02-27 15:59 PST (History)
3 users (show)

See Also:

patch (2.33 KB, patch)
2014-02-27 15:55 PST, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-02-27 15:52:59 PST

Seeing a crash in RemoteLayerTreePropertyApplier::applyPropertiesToLayer when going from having layer contents to not having layer contents. We're dereferencing the RemoteLayerBacking without checking if it exists, in the accelerated drawing codepath.

Also, this #if structure is disturbing (conditional control flow scares me), so rework it a bit.
Comment 1 Tim Horton 2014-02-27 15:55:11 PST
Created attachment 225421 [details]
Comment 2 Tim Horton 2014-02-27 15:56:36 PST
Comment on attachment 225421 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=225421&action=review

> Source/WebKit2/ChangeLog:11
> +        We were dereferencing the RemoteLayerBacking without checking if it exists,

Comment 3 Tim Horton 2014-02-27 15:59:04 PST