Bug 129454 - Slow cases for function.apply and function.call should not require vm re-entry
Summary: Slow cases for function.apply and function.call should not require vm re-entry
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on: 129488
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-27 14:52 PST by Oliver Hunt
Modified: 2014-02-28 08:42 PST (History)
1 user (show)

See Also:


Attachments
Patch (29.60 KB, patch)
2014-02-27 14:55 PST, Oliver Hunt
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2014-02-27 14:52:47 PST
Slow cases for function.apply and function.call should not require vm re-entry
Comment 1 Oliver Hunt 2014-02-27 14:55:41 PST
Created attachment 225415 [details]
Patch
Comment 2 Geoffrey Garen 2014-02-27 15:09:37 PST
Comment on attachment 225415 [details]
Patch

r=me

Seems like a js-regress test is in order, in which someone aliases .call or .apply.
Comment 3 Oliver Hunt 2014-02-27 15:19:56 PST
Committed r164835: <http://trac.webkit.org/changeset/164835>
Comment 4 Csaba Osztrogonác 2014-02-28 08:42:05 PST
(In reply to comment #3)
> Committed r164835: <http://trac.webkit.org/changeset/164835>

It caused regression on 32 bit, see https://bugs.webkit.org/show_bug.cgi?id=129488 for details.