Bug 129436 - [Mac][WK2] Remove hardcoded Cmd+B and Cmd+I from WKView.mm
Summary: [Mac][WK2] Remove hardcoded Cmd+B and Cmd+I from WKView.mm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-27 10:11 PST by Alexey Proskuryakov
Modified: 2014-02-27 11:14 PST (History)
4 users (show)

See Also:

Attachments
proposed patch (2.33 KB, patch)
2014-02-27 10:13 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-02-27 10:11:22 PST 
We hardcode Cmd+B and Cmd+I in WebKit1 for historic reasons, but it doesn't look like there is any need to do this in WebKit2.

I tested GMail and iCloud e-mail, and these shortcuts work there even without this code (presumably because both implemented them in JS for Firefox on Mac). Mail.app has these shortcuts in menu, so again, hardcoding is unnecessary.

The reason I want to remove this is that _handleStyleKeyEquivalent looks at EditorState, which is not going to be supported in the future.
Comment 1 Alexey Proskuryakov 2014-02-27 10:13:11 PST 
Created attachment 225387 [details]
proposed patch
Comment 2 WebKit Commit Bot 2014-02-27 11:14:37 PST 
Comment on attachment 225387 [details]
proposed patch

Clearing flags on attachment: 225387

Committed r164818: <http://trac.webkit.org/changeset/164818>
Comment 3 WebKit Commit Bot 2014-02-27 11:14:39 PST 
All reviewed patches have been landed.  Closing bug.