Bug 129432 - [GTK] Finetune captions menu as per design team
Summary: [GTK] Finetune captions menu as per design team
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
Depends on:
Reported: 2014-02-27 09:33 PST by Xabier Rodríguez Calvar
Modified: 2014-02-28 02:01 PST (History)
10 users (show)

See Also:

Patch (4.11 KB, patch)
2014-02-27 09:37 PST, Xabier Rodríguez Calvar
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2014-02-27 09:33:32 PST
[GTK] Finetune captions menu as per design team
Comment 1 Xabier Rodríguez Calvar 2014-02-27 09:37:32 PST
Created attachment 225381 [details]
Comment 2 Xabier Rodríguez Calvar 2014-02-27 15:35:42 PST
Small explanation:

http://imgur.com/kPxvS6G,JVhRQjf#0 In the first image, you can see that the dialog is centered (as usual) con the menu button but as it is too close to right side, a part of it is being shown out of the panel space and the effect is weird. Apart from that, designers asked to do some tweaking to the header file.
Comment 3 WebKit Commit Bot 2014-02-28 02:00:57 PST
Comment on attachment 225381 [details]

Clearing flags on attachment: 225381

Committed r164857: <http://trac.webkit.org/changeset/164857>
Comment 4 WebKit Commit Bot 2014-02-28 02:01:00 PST
All reviewed patches have been landed.  Closing bug.