Bug 129427 - Some small modernizing tweaks to the coding style guide
Summary: Some small modernizing tweaks to the coding style guide
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-27 08:59 PST by Darin Adler
Modified: 2014-03-03 14:48 PST (History)
2 users (show)

See Also:


Attachments
Patch (5.70 KB, patch)
2014-02-27 09:03 PST, Darin Adler
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2014-02-27 08:59:11 PST
Change coding style guide to specify nullptr instead of 0, and other small modernizing tweaks
Comment 1 Darin Adler 2014-02-27 09:03:42 PST
Created attachment 225374 [details]
Patch
Comment 2 Alexey Proskuryakov 2014-02-28 10:05:56 PST
Comment on attachment 225374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225374&action=review

> Websites/webkit.org/ChangeLog:14
> +        without non-WebKit-style abbreviations and such. Use auto& instead of const auto& in for loop
> +        example, since that's normally preferred. Changed section title to say "zero" instead of "0".

This is one part I'm not sure of. We have a lot of "const auto&" loop variables currently in the tree, and I personally like those.
Comment 3 Darin Adler 2014-02-28 12:39:11 PST
(In reply to comment #2)
> This is one part I'm not sure of. We have a lot of "const auto&" loop variables currently in the tree, and I personally like those.

The compiler will automatically propagate the const from the collection if begin/end are overloaded suitably.

How critical is it to narrow the reference to read-only in cases where the access to the collection is not already read-only? Is it worth an extra keyword on every one of these for loops?
Comment 4 Darin Adler 2014-03-01 15:24:49 PST
Comment on attachment 225374 [details]
Patch

For now I will land with "auto&". We can change back later if we confirm that "const auto&" is preferred.
Comment 5 Darin Adler 2014-03-01 15:25:21 PST
Committed r164930: <http://trac.webkit.org/changeset/164930>
Comment 6 Joseph Pecoraro 2014-03-03 14:48:14 PST
Comment on attachment 225374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225374&action=review

> Websites/webkit.org/ChangeLog:17
> +        over index iteration in vector iteration example and also showed use of unsigned rather than
> +        size_t since that is almost always what we want. Eliminated the use of PassOwnPtr in the "return

Why is "unsigned rather than size_t" preferred? Shouldn't we match the type that the method / object produces?