Bug 129424 - JSType upper limit (0xff) assertion can be removed
Summary: JSType upper limit (0xff) assertion can be removed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-27 05:35 PST by Gergő Balogh
Modified: 2014-02-27 10:44 PST (History)
4 users (show)

See Also:


Attachments
patch (1.24 KB, patch)
2014-02-27 05:44 PST, Gergő Balogh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gergő Balogh 2014-02-27 05:35:31 PST
There is no point to assert that the JSType is less or equals than 0xff, because it defined to based on uint8_t.
uint8_t by definition in the standard is an 8 byte type.
Comment 1 Gergő Balogh 2014-02-27 05:44:39 PST
Created attachment 225361 [details]
patch
Comment 2 Geoffrey Garen 2014-02-27 10:11:42 PST
Comment on attachment 225361 [details]
patch

r=me
Comment 3 WebKit Commit Bot 2014-02-27 10:44:22 PST
Comment on attachment 225361 [details]
patch

Clearing flags on attachment: 225361

Committed r164815: <http://trac.webkit.org/changeset/164815>
Comment 4 WebKit Commit Bot 2014-02-27 10:44:25 PST
All reviewed patches have been landed.  Closing bug.