Bug 129408 - Ranges given to createMarkupInternal might not be canonicalized
Summary: Ranges given to createMarkupInternal might not be canonicalized
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-26 16:18 PST by Myles C. Maxfield
Modified: 2014-02-26 17:21 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.75 KB, patch)
2014-02-26 16:20 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (2.04 KB, patch)
2014-02-26 17:17 PST, Myles C. Maxfield
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-02-26 16:18:06 PST
Ranges given to createMarkupInternal might not be canonicalized
Comment 1 Myles C. Maxfield 2014-02-26 16:20:42 PST
Created attachment 225317 [details]
Patch
Comment 2 Ryosuke Niwa 2014-02-26 17:00:22 PST
Comment on attachment 225317 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225317&action=review

> Source/WebCore/ChangeLog:9
> +        No new tests because this codepath will only be reached via SPI.
> +

We need to describe why we're making this change.

> Source/WebCore/editing/markup.cpp:575
> -    if (body && areRangesEqual(VisibleSelection::selectionFromContentsOfNode(body).toNormalizedRange().get(), &range))
> +    if (body && areRangesEqual(VisibleSelection::selectionFromContentsOfNode(body).toNormalizedRange().get(),
> +        VisibleSelection(range.startPosition(), range.endPosition()).toNormalizedRange().get()))

This is very inefficient way of checking this condition anyways.
It's probably better to do VisiblePosition(firstPositionInNode(body)) == VisiblePosition(range.startPosition()) and the similar for the end.
Comment 3 Myles C. Maxfield 2014-02-26 17:17:04 PST
Created attachment 225326 [details]
Patch
Comment 4 Myles C. Maxfield 2014-02-26 17:21:29 PST
http://trac.webkit.org/changeset/164763