WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
129398
Prepare for overflow scrolling nodes in the scrolling tree
https://bugs.webkit.org/show_bug.cgi?id=129398
Summary
Prepare for overflow scrolling nodes in the scrolling tree
Simon Fraser (smfr)
Reported
2014-02-26 15:01:08 PST
Prepare for overflow scrolling nodes in the scrolling tree
Attachments
Patch
(35.04 KB, patch)
2014-02-26 15:06 PST
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Patch
(35.05 KB, patch)
2014-02-26 16:28 PST
,
Simon Fraser (smfr)
thorton
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2014-02-26 15:06:29 PST
Created
attachment 225303
[details]
Patch
Simon Fraser (smfr)
Comment 2
2014-02-26 16:28:46 PST
Created
attachment 225320
[details]
Patch
Tim Horton
Comment 3
2014-02-26 16:33:38 PST
Comment on
attachment 225320
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=225320&action=review
> Source/WebCore/rendering/RenderLayerCompositor.cpp:3493 > + else > + ASSERT_NOT_REACHED();
I think you want curly braces here
> Source/WebCore/rendering/RenderLayerCompositor.h:408 > + FixedOrSticky = 1 << 0,
ViewportConstrained? :D
Tim Horton
Comment 4
2014-02-26 16:34:18 PST
(In reply to
comment #3
)
> (From update of
attachment 225320
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=225320&action=review
> > > Source/WebCore/rendering/RenderLayerCompositor.cpp:3493 > > + else > > + ASSERT_NOT_REACHED(); > > I think you want curly braces here
Or maybe it's fine?
Simon Fraser (smfr)
Comment 5
2014-02-26 16:59:17 PST
https://trac.webkit.org/r164759
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug