Bug 129398 - Prepare for overflow scrolling nodes in the scrolling tree
Summary: Prepare for overflow scrolling nodes in the scrolling tree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-26 15:01 PST by Simon Fraser (smfr)
Modified: 2014-02-26 16:59 PST (History)
13 users (show)

See Also:


Attachments
Patch (35.04 KB, patch)
2014-02-26 15:06 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (35.05 KB, patch)
2014-02-26 16:28 PST, Simon Fraser (smfr)
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-02-26 15:01:08 PST
Prepare for overflow scrolling nodes in the scrolling tree
Comment 1 Simon Fraser (smfr) 2014-02-26 15:06:29 PST
Created attachment 225303 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-02-26 16:28:46 PST
Created attachment 225320 [details]
Patch
Comment 3 Tim Horton 2014-02-26 16:33:38 PST
Comment on attachment 225320 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225320&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:3493
> +        else
> +            ASSERT_NOT_REACHED();

I think you want curly braces here

> Source/WebCore/rendering/RenderLayerCompositor.h:408
> +        FixedOrSticky = 1 << 0,

ViewportConstrained? :D
Comment 4 Tim Horton 2014-02-26 16:34:18 PST
(In reply to comment #3)
> (From update of attachment 225320 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=225320&action=review
> 
> > Source/WebCore/rendering/RenderLayerCompositor.cpp:3493
> > +        else
> > +            ASSERT_NOT_REACHED();
> 
> I think you want curly braces here

Or maybe it's fine?
Comment 5 Simon Fraser (smfr) 2014-02-26 16:59:17 PST
https://trac.webkit.org/r164759