RESOLVED FIXED 129380
[GTK][CMake] build-webkit should rerun cmake if the Makefile is missing 
https://bugs.webkit.org/show_bug.cgi?id=129380
Summary [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
Martin Robinson
Reported 2014-02-26 10:43:18 PST
We try to avoid running cmake when we don't have to. There are circumstances where CMake creates the CMake cache, but not the Makefile or the Makefile is removed. In those cases, we should rerun cmake instead of skipping it.
Attachments
Patch (1.42 KB, patch)
2014-02-26 11:17 PST, Martin Robinson 		pnormand: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2014-02-26 11:17:30 PST
Created attachment 225268 [details] Patch
Philippe Normand
Comment 2 2014-03-05 08:07:42 PST
Comment on attachment 225268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225268&action=review > Tools/Scripts/webkitdirs.pm:1982 > + if (isGtk() && -e cmakeCachePath() && -e File::Spec->catdir(baseProductDir(), configuration(), "Makefile")) { Shouldn't it be catfile?
Philippe Normand
Comment 3 2014-03-05 08:26:51 PST
Comment on attachment 225268 [details] Patch Well it would work with catdir but if you can use catfile for consistency sake before landing it'd be great :)
Martin Robinson
Comment 4 2014-03-05 08:46:46 PST
Committed r165111: <http://trac.webkit.org/changeset/165111>
Note You need to log in before you can comment on or make changes to this bug.