Bug 129376 - runscript: line 42: /bin/ls: Argument list too long
Summary: runscript: line 42: /bin/ls: Argument list too long
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-26 10:19 PST by Mark Hahnenberg
Modified: 2014-02-26 11:12 PST (History)
1 user (show)

See Also:


Attachments
Patch (1.35 KB, patch)
2014-02-26 10:22 PST, Mark Hahnenberg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-02-26 10:19:52 PST
This occurs on line 42 in jsc-stress-test-helpers/shell-runner.sh. The "test_script_*" can expand to more things than can be passed as arguments on the command line. We should use find instead, which generates the list of files rather than expanding them all on the command line and spitting them back out.
Comment 1 Mark Hahnenberg 2014-02-26 10:20:06 PST
<rdar://problem/16169656>
Comment 2 Mark Hahnenberg 2014-02-26 10:22:39 PST
Created attachment 225264 [details]
Patch
Comment 3 Michael Saboff 2014-02-26 10:25:00 PST
Comment on attachment 225264 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2014-02-26 11:11:58 PST
Comment on attachment 225264 [details]
Patch

Clearing flags on attachment: 225264

Committed r164727: <http://trac.webkit.org/changeset/164727>
Comment 5 WebKit Commit Bot 2014-02-26 11:12:00 PST
All reviewed patches have been landed.  Closing bug.