Bug 129375 - [CustomGetter] attributes must be in the prototype chain
Summary: [CustomGetter] attributes must be in the prototype chain
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago de Barros Lacerda
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-26 10:18 PST by Thiago de Barros Lacerda
Modified: 2014-10-30 06:14 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.75 KB, patch)
2014-02-26 12:38 PST, Thiago de Barros Lacerda 		sam: review-
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (499.84 KB, application/zip)
2014-02-26 13:31 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (604.28 KB, application/zip)
2014-02-26 14:23 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (589.52 KB, application/zip)
2014-02-26 15:17 PST, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago de Barros Lacerda 2014-02-26 10:18:51 PST 
https://webkit.org/b/127969 moved all attributes that have automatic generated getters to the prototype chain.
[CustomGetter] attributes, which getters are not trivially generated, must be moved to the prototype chain as well.
Comment 1 Thiago de Barros Lacerda 2014-02-26 12:38:48 PST 
Created attachment 225282 [details]
Patch
Comment 2 Build Bot 2014-02-26 13:31:13 PST 
Comment on attachment 225282 [details]
Patch

Attachment 225282 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5446586574307328

New failing tests:
svg/masking/mask-negative-scale.svg
http/tests/security/xss-DENIED-assign-location-href-javascript.html
Comment 3 Build Bot 2014-02-26 13:31:15 PST 
Created attachment 225290 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 4 Build Bot 2014-02-26 14:23:08 PST 
Comment on attachment 225282 [details]
Patch

Attachment 225282 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5851453277077504

New failing tests:
svg/masking/mask-negative-scale.svg
http/tests/security/xss-DENIED-assign-location-href-javascript.html
http/tests/security/cross-frame-access-enumeration.html
Comment 5 Build Bot 2014-02-26 14:23:10 PST 
Created attachment 225299 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 6 Build Bot 2014-02-26 15:17:08 PST 
Comment on attachment 225282 [details]
Patch

Attachment 225282 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5369119322931200

New failing tests:
http/tests/security/xss-DENIED-assign-location-href-javascript.html
http/tests/security/cross-frame-access-enumeration.html
Comment 7 Build Bot 2014-02-26 15:17:12 PST 
Created attachment 225305 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 8 Sam Weinig 2014-10-30 06:14:45 PDT 
Comment on attachment 225282 [details]
Patch

This needs a test case.