129370 – FastMalloc should use vm_page_shift intead of PAGE_SHIFT.

RESOLVED FIXED 129370

FastMalloc should use vm_page_shift intead of PAGE_SHIFT.

https://bugs.webkit.org/show_bug.cgi?id=129370

Summary FastMalloc should use vm_page_shift intead of PAGE_SHIFT.

Gavin Barraclough

Reported 2014-02-26 06:55:34 PST

Previously we used PAGE_SHIFT to initialize kPageShift. Since this was a constant, it could be used to calculate other contants used in the code. Some of these values are used in the definition of certain data structures (specifiying the length of some array members). Make kPageShift & dependent properties variables setup during initialization. Add upper bound values (K_PAGE_SHIFT_MAX, K_NUM_CLASSES_MAX) for use in cases where we need a constant.

Attachments
Fix (21.24 KB, patch) 2014-02-26 06:56 PST, Gavin Barraclough	no flags	Details Formatted Diff Diff
Speculative efl/gtk build fix (21.28 KB, patch) 2014-02-26 07:12 PST, Gavin Barraclough	no flags	Details Formatted Diff Diff
Ooops, stray semi. (21.41 KB, patch) 2014-02-26 08:45 PST, Gavin Barraclough	ggaren: review+	Details Formatted Diff Diff
Fix for Mark's comments. (2.63 KB, patch) 2014-02-26 12:48 PST, Gavin Barraclough	mrowe: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Gavin Barraclough

Comment 1 2014-02-26 06:56:27 PST

Created attachment 225251 [details] Fix

WebKit Commit Bot

Comment 2 2014-02-26 06:58:32 PST

Attachment 225251 [details] did not pass style-queue: ERROR: Source/WTF/wtf/FastMalloc.cpp:665: num_objects_to_move is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:761: class_to_size is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:764: class_to_pages is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:915: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:918: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:916: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:917: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:920: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:923: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:925: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:927: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:928: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:930: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:931: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1163: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1171: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1444: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1444: tc_slots_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:1666: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1684: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1692: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1693: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1926: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1942: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2245: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2386: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2464: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2531: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2628: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2762: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/FastMalloc.cpp:2762: Extra space between FreeList and list_ [whitespace/declaration] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2762: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2762: list_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:2818: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2831: central_cache is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:2987: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3012: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3059: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3075: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3130: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3213: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3300: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3323: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3398: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3691: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3713: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3751: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4040: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4055: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4109: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4161: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4482: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/FastMalloc.cpp:4482: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/FastMalloc.cpp:4482: Use 0 instead of NULL. [readability/null] [5] ERROR: Source/WTF/wtf/FastMalloc.cpp:4482: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4483: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4725: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:4725: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/FastMalloc.cpp:4725: Use 0 instead of NULL. [readability/null] [5] ERROR: Source/WTF/wtf/FastMalloc.cpp:4725: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4726: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 61 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gavin Barraclough

Comment 3 2014-02-26 06:59:36 PST

<rdar://problem/15483701>

Gavin Barraclough

Comment 4 2014-02-26 07:12:10 PST

Created attachment 225252 [details] Speculative efl/gtk build fix

WebKit Commit Bot

Comment 5 2014-02-26 07:13:16 PST

Attachment 225252 [details] did not pass style-queue: ERROR: Source/WTF/wtf/FastMalloc.cpp:665: num_objects_to_move is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:761: class_to_size is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:764: class_to_pages is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:915: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:918: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:916: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:917: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:920: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:923: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:925: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:927: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:928: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:930: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:931: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1163: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1171: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1444: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1444: tc_slots_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:1666: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1684: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1692: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1693: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1926: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1942: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2245: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2386: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2464: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2531: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2628: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2762: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/FastMalloc.cpp:2762: Extra space between FreeList and list_ [whitespace/declaration] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2762: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2762: list_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:2818: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2831: central_cache is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:2987: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3012: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3059: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3075: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3130: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3213: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3300: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3323: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3398: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3691: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3713: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3751: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4040: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4055: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4109: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4161: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4482: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/FastMalloc.cpp:4482: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/FastMalloc.cpp:4482: Use 0 instead of NULL. [readability/null] [5] ERROR: Source/WTF/wtf/FastMalloc.cpp:4482: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4483: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4725: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:4725: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/FastMalloc.cpp:4725: Use 0 instead of NULL. [readability/null] [5] ERROR: Source/WTF/wtf/FastMalloc.cpp:4725: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4726: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 61 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gavin Barraclough

Comment 6 2014-02-26 08:45:49 PST

Created attachment 225259 [details] Ooops, stray semi.

WebKit Commit Bot

Comment 7 2014-02-26 08:48:47 PST

Attachment 225259 [details] did not pass style-queue: ERROR: Source/WTF/wtf/FastMalloc.cpp:666: num_objects_to_move is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:762: class_to_size is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:765: class_to_pages is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:916: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:919: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:917: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:918: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:921: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:924: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:926: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:928: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:929: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:931: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:932: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1164: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1172: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1445: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1445: tc_slots_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:1667: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1685: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1693: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1694: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1927: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:1943: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2246: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2387: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2465: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2532: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2629: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2763: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/FastMalloc.cpp:2763: Extra space between FreeList and list_ [whitespace/declaration] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2763: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2763: list_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:2819: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:2832: central_cache is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:2988: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3013: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3060: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3076: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3131: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3214: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3301: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3324: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3399: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3692: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3714: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:3752: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4041: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4056: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4110: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4162: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4483: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/FastMalloc.cpp:4483: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/FastMalloc.cpp:4483: Use 0 instead of NULL. [readability/null] [5] ERROR: Source/WTF/wtf/FastMalloc.cpp:4483: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4484: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4726: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/FastMalloc.cpp:4726: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/FastMalloc.cpp:4726: Use 0 instead of NULL. [readability/null] [5] ERROR: Source/WTF/wtf/FastMalloc.cpp:4726: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/FastMalloc.cpp:4727: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 61 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Geoffrey Garen

Comment 8 2014-02-26 09:59:34 PST

Comment on attachment 225259 [details] Ooops, stray semi. r=me

Gavin Barraclough

Comment 9 2014-02-26 11:11:59 PST

Committed revision 164728.

Mark Rowe (bdash)

Comment 10 2014-02-26 11:30:29 PST

Comment on attachment 225259 [details] Ooops, stray semi. View in context: https://bugs.webkit.org/attachment.cgi?id=225259&action=review > Source/WTF/wtf/FastMalloc.cpp:1685 > - typedef TCMalloc_PageMap3<64 - kPageShift - kBitsUnusedOn64Bit> Type; > + typedef TCMalloc_PageMap3<64 - K_PAGE_SHIFT_MAX - kBitsUnusedOn64Bit> Type; Doesn't this lead to the page map using fewer bits than it was before? It seems like this will cause some page addresses to no longer be representable in the map when using 4K pages. Am I missing something?

Gavin Barraclough

Comment 11 2014-02-26 12:48:51 PST

Created attachment 225283 [details] Fix for Mark's comments.

Mark Rowe (bdash)

Comment 12 2014-02-26 12:51:57 PST

Comment on attachment 225283 [details] Fix for Mark's comments. View in context: https://bugs.webkit.org/attachment.cgi?id=225283&action=review > Source/WTF/ChangeLog:14 > + larger than absolutely necessary, rather that potentially too small. "rather that" → "rather than"

Gavin Barraclough

Comment 13 2014-02-26 13:12:13 PST

Transmitting file data .. Committed revision 164742.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware Unspecified

OS Unspecified

Product WebKit

Component Web Template Framework

Assignee

Gavin Barraclough

Reported

2014-02-26 06:55 PST

Modified

2014-02-26 13:12 PST History

CC List

6 users Show

URL

Keywords

Depends on

Blocks