RESOLVED FIXED 129361
Avoid unnecessary HTML Collection invalidations for id and name attribute changes 
https://bugs.webkit.org/show_bug.cgi?id=129361
Summary Avoid unnecessary HTML Collection invalidations for id and name attribute cha...
Ryosuke Niwa
Reported 2014-02-25 20:50:58 PST
Avoid unnecessary HTML Collection invalidations for id and name attribute changes
Attachments
Fixes the bug (13.78 KB, patch)
2014-02-25 21:02 PST, Ryosuke Niwa 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2014-02-25 21:02:46 PST
Created attachment 225218 [details] Fixes the bug
Benjamin Poulain
Comment 2 2014-02-25 23:54:08 PST
Comment on attachment 225218 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=225218&action=review > Source/WebCore/dom/NodeRareData.h:233 > + for (auto it = m_atomicNameCaches.begin(), end = m_atomicNameCaches.end(); it != end; ++it) { You could use a for-each loop here and in the following loops. > Source/WebCore/dom/NodeRareData.h:237 > + list.invalidateCache(0); Shouldn't you just call list.invalidateCache() here?
Ryosuke Niwa
Comment 3 2014-02-26 00:19:11 PST
Thanks for the review. (In reply to comment #2) > (From update of attachment 225218 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=225218&action=review > > > Source/WebCore/dom/NodeRareData.h:233 > > + for (auto it = m_atomicNameCaches.begin(), end = m_atomicNameCaches.end(); it != end; ++it) { > > You could use a for-each loop here and in the following loops. Fixed. > > Source/WebCore/dom/NodeRareData.h:237 > > + list.invalidateCache(0); > > Shouldn't you just call list.invalidateCache() here? Fixed.
Ryosuke Niwa
Comment 4 2014-02-26 00:20:48 PST
Committed r164707: <http://trac.webkit.org/changeset/164707>
Note You need to log in before you can comment on or make changes to this bug.