Bug 129328 - REGRESSION: All inspector-protocol/model very frequently assert in IDBRequest::~IDBRequest
Summary: REGRESSION: All inspector-protocol/model very frequently assert in IDBRequest...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
: 129583 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-02-25 13:17 PST by Alexey Proskuryakov
Modified: 2014-03-02 20:44 PST (History)
12 users (show)

See Also:

Attachments
Patch (2.83 KB, patch)
2014-03-02 17:42 PST, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (539.37 KB, application/zip)
2014-03-02 18:13 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (489.35 KB, application/zip)
2014-03-02 19:05 PST, Build Bot 		no flags Details
Patch (3.77 KB, patch)
2014-03-02 19:54 PST, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-02-25 13:17:08 PST 
E.g.:

http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r164653%20(16253)/inspector-protocol/model/content-node-region-info-crash-log.txt

Brady tells me that even though these tests seem unrelated, Inspector tests always do some IndexedDB work now.
Comment 1 Radar WebKit Bug Importer 2014-02-25 13:17:55 PST 
<rdar://problem/16164208>
Comment 2 Alexey Proskuryakov 2014-02-25 13:19:54 PST 
Skipped all these tests in <http://trac.webkit.org/r164668>.
Comment 3 Timothy Hatcher 2014-03-02 17:23:58 PST 
*** Bug 129583 has been marked as a duplicate of this bug. ***
Comment 4 Timothy Hatcher 2014-03-02 17:42:34 PST 
Created attachment 225619 [details]
Patch
Comment 5 Build Bot 2014-03-02 18:13:08 PST 
Comment on attachment 225619 [details]
Patch

Attachment 225619 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6464029161684992

New failing tests:
inspector-protocol/model/probe-manager-add-remove-actions.html
Comment 6 Build Bot 2014-03-02 18:13:10 PST 
Created attachment 225623 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 7 Build Bot 2014-03-02 19:05:24 PST 
Comment on attachment 225619 [details]
Patch

Attachment 225619 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6705165000245248

New failing tests:
inspector-protocol/model/probe-manager-add-remove-actions.html
Comment 8 Build Bot 2014-03-02 19:05:27 PST 
Created attachment 225626 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 9 BJ Burg 2014-03-02 19:51:23 PST 
Test failure is unrelated, it just needs to be rebaselined. I think we are just firing more breakpoint resolved events now, and it used to be skipped so nobody saw it.
Comment 10 Timothy Hatcher 2014-03-02 19:52:51 PST 
(In reply to comment #9)
> Test failure is unrelated, it just needs to be rebaselined. I think we are just firing more breakpoint resolved events now, and it used to be skipped so nobody saw it.

Yep, it is from my change earlier this week to enable all breakpoints when a new one is added.
Comment 11 Timothy Hatcher 2014-03-02 19:54:45 PST 
Created attachment 225630 [details]
Patch
Comment 12 WebKit Commit Bot 2014-03-02 20:44:01 PST 
Comment on attachment 225630 [details]
Patch

Clearing flags on attachment: 225630

Committed r164967: <http://trac.webkit.org/changeset/164967>
Comment 13 WebKit Commit Bot 2014-03-02 20:44:04 PST 
All reviewed patches have been landed.  Closing bug.