Bug 129291 - [GTK] Reduplicate common.top_level_path in scripts
Summary: [GTK] Reduplicate common.top_level_path in scripts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-24 23:28 PST by Martin Robinson
Modified: 2014-02-26 12:49 PST (History)
2 users (show)

See Also:

Attachments
Patch (6.92 KB, patch)
2014-02-24 23:35 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch (6.73 KB, patch)
2014-02-24 23:44 PST, Martin Robinson 		pnormand: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2014-02-24 23:28:10 PST 
Duplicating this very simple function prevents us having almost every GTK+ script depend on the jhbuild script and a lot of awkward Python system path manipulation.
Comment 1 Martin Robinson 2014-02-24 23:35:55 PST 
Created attachment 225123 [details]
Patch
Comment 2 Carlos Garcia Campos 2014-02-24 23:42:19 PST 
Comment on attachment 225123 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225123&action=review

> Tools/gtk/check-gdom-symbols:29
> +def top_level_path(*args):
> +    global top_level_dir
> +    if not top_level_dir:
> +        top_level_dir = os.path.join(os.path.dirname(__file__), '..', '..')
> +    return os.path.join(*(top_level_dir,) + args)

Why do we need this here if we are using common?
Comment 3 Martin Robinson 2014-02-24 23:44:29 PST 
Created attachment 225124 [details]
Patch
Comment 4 Martin Robinson 2014-02-24 23:45:25 PST 
(In reply to comment #2)

> Why do we need this here if we are using common?

Whoops! Forgot to save a file before uploading. I've uploaded a new patch.
Comment 5 Martin Robinson 2014-02-26 12:49:19 PST 
Committed r164739: <http://trac.webkit.org/changeset/164739>