Bug 129277 - [iOS] Show status image when playing video to external device
Summary: [iOS] Show status image when playing video to external device
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-24 17:02 PST by Eric Carlson
Modified: 2014-02-25 12:24 PST (History)
7 users (show)

See Also:


Attachments
Proposed patch. (36.51 KB, patch)
2014-02-24 17:23 PST, Eric Carlson
no flags Details | Formatted Diff | Diff
Updated patch (36.54 KB, patch)
2014-02-24 20:01 PST, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2014-02-24 17:02:57 PST
Move all of the logic for "IOS_AIRPLAY" from HTMLMediaElement into HTMLMediaSession, and implement the media engine potion of the API for our AVFoundation based engine.
Comment 1 Eric Carlson 2014-02-24 17:23:30 PST
Created attachment 225105 [details]
Proposed patch.
Comment 2 WebKit Commit Bot 2014-02-24 17:24:56 PST
Attachment 225105 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
ERROR: Source/WebCore/html/HTMLMediaElement.cpp:2460:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Carlson 2014-02-24 20:01:30 PST
Created attachment 225116 [details]
Updated patch
Comment 4 Jer Noble 2014-02-25 10:16:46 PST
Comment on attachment 225116 [details]
Updated patch

r=me.  Great logging!
Comment 5 WebKit Commit Bot 2014-02-25 12:24:31 PST
Comment on attachment 225116 [details]
Updated patch

Clearing flags on attachment: 225116

Committed r164661: <http://trac.webkit.org/changeset/164661>
Comment 6 WebKit Commit Bot 2014-02-25 12:24:33 PST
All reviewed patches have been landed.  Closing bug.