RESOLVED FIXED 129276
Use RetainPtrs for two WKContentView data members 
https://bugs.webkit.org/show_bug.cgi?id=129276
Summary Use RetainPtrs for two WKContentView data members
Simon Fraser (smfr)
Reported 2014-02-24 16:33:29 PST
Use RetainPtrs for two WKContentView data members
Attachments
Patch (5.12 KB, patch)
2014-02-24 16:35 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (5.86 KB, patch)
2014-02-24 18:40 PST, Simon Fraser (smfr) 		benjamin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2014-02-24 16:35:45 PST
Created attachment 225103 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-02-24 16:36:09 PST
Depends on earlier patch.
Simon Fraser (smfr)
Comment 3 2014-02-24 18:40:23 PST
Created attachment 225109 [details] Patch
Benjamin Poulain
Comment 4 2014-02-24 18:42:41 PST
Comment on attachment 225109 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225109&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:113 > @property (nonatomic, readonly) BOOL isEditable; > +@property (readonly, nonatomic) const WebKit::InteractionInformationAtPosition& positionInformation; > +@property (readonly, nonatomic) const WebKit::WKAutoCorrectionData& autocorrectionData; Switch nonatomic and readonly here for consistency? > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:188 > + [_formAccessoryView release]; _formAccessoryView = nil;
Simon Fraser (smfr)
Comment 5 2014-02-24 18:54:12 PST
https://trac.webkit.org/r164622
Note You need to log in before you can comment on or make changes to this bug.