Bug 129276 - Use RetainPtrs for two WKContentView data members
Summary: Use RetainPtrs for two WKContentView data members
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-24 16:33 PST by Simon Fraser (smfr)
Modified: 2014-02-24 18:54 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.12 KB, patch)
2014-02-24 16:35 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (5.86 KB, patch)
2014-02-24 18:40 PST, Simon Fraser (smfr) 		benjamin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-02-24 16:33:29 PST 
Use RetainPtrs for two WKContentView data members
Comment 1 Simon Fraser (smfr) 2014-02-24 16:35:45 PST 
Created attachment 225103 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-02-24 16:36:09 PST 
Depends on earlier patch.
Comment 3 Simon Fraser (smfr) 2014-02-24 18:40:23 PST 
Created attachment 225109 [details]
Patch
Comment 4 Benjamin Poulain 2014-02-24 18:42:41 PST 
Comment on attachment 225109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225109&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:113
>  @property (nonatomic, readonly) BOOL isEditable;
> +@property (readonly, nonatomic) const WebKit::InteractionInformationAtPosition& positionInformation;
> +@property (readonly, nonatomic) const WebKit::WKAutoCorrectionData& autocorrectionData;

Switch nonatomic and readonly here for consistency?

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:188
> +    [_formAccessoryView release];

_formAccessoryView = nil;
Comment 5 Simon Fraser (smfr) 2014-02-24 18:54:12 PST 
https://trac.webkit.org/r164622