Bug 129260 - Web Inspector: Toolbar is all white on non-Mac platforms
Summary: Web Inspector: Toolbar is all white on non-Mac platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-02-24 11:12 PST by Timothy Hatcher
Modified: 2014-02-24 19:50 PST (History)
4 users (show)

See Also:


Attachments
Patch (4.63 KB, patch)
2014-02-24 11:16 PST, Timothy Hatcher
joepeck: review+
timothy: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2014-02-24 11:12:53 PST
The toolbar is all white on Windows and Linux. We should give those platforms a default toolbar background.
Comment 1 Timothy Hatcher 2014-02-24 11:16:01 PST
Created attachment 225076 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2014-02-24 11:16:27 PST
<rdar://problem/16149805>
Comment 3 Joseph Pecoraro 2014-02-24 11:45:45 PST
Comment on attachment 225076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225076&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Main.js:203
> +    } else if (navigator.platform.contains("Win"))
> +        document.body.classList.add("windows-platform");
> +    else if (navigator.platform.contains("Linux"))
> +        document.body.classList.add("linux-platform");
> +    else
> +        document.body.classList.add("other-platform");

Should we use InspectorFrontendHost.platform instead? It would simplify things a bit.
Comment 4 Timothy Hatcher 2014-02-24 13:24:40 PST
https://trac.webkit.org/changeset/164604
Comment 5 Antoine Quint 2014-02-24 15:23:00 PST
Comment on attachment 225076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225076&action=review

> Source/WebInspectorUI/UserInterface/Views/Toolbar.css:58
> +    background-image: -webkit-linear-gradient(top, rgb(233, 233, 233), rgb(229, 229, 229));

You could have used the W3C syntax as follows, with the default value for the orientation: linear-gradient(rgb(229, 229, 229), rgb(233, 233, 233));
Comment 6 Timothy Hatcher 2014-02-24 19:50:06 PST
Comment on attachment 225076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225076&action=review

>> Source/WebInspectorUI/UserInterface/Views/Toolbar.css:58
>> +    background-image: -webkit-linear-gradient(top, rgb(233, 233, 233), rgb(229, 229, 229));
> 
> You could have used the W3C syntax as follows, with the default value for the orientation: linear-gradient(rgb(229, 229, 229), rgb(233, 233, 233));

I fixed all our gradients to use the in prefixed version in a follow up.