Bug 129260 – Web Inspector: Toolbar is all white on non-Mac platforms

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Timothy Hatcher]

The toolbar is all white on Windows and Linux. We should give those platforms a default toolbar background.

[Timothy Hatcher]

Created attachment 225076 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/16149805>

[Joseph Pecoraro]

Comment on attachment 225076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225076&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Main.js:203
> +    } else if (navigator.platform.contains("Win"))
> +        document.body.classList.add("windows-platform");
> +    else if (navigator.platform.contains("Linux"))
> +        document.body.classList.add("linux-platform");
> +    else
> +        document.body.classList.add("other-platform");

Should we use InspectorFrontendHost.platform instead? It would simplify things a bit.

[Timothy Hatcher]

https://trac.webkit.org/changeset/164604

[Antoine Quint]

Comment on attachment 225076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225076&action=review

> Source/WebInspectorUI/UserInterface/Views/Toolbar.css:58
> +    background-image: -webkit-linear-gradient(top, rgb(233, 233, 233), rgb(229, 229, 229));

You could have used the W3C syntax as follows, with the default value for the orientation: linear-gradient(rgb(229, 229, 229), rgb(233, 233, 233));

[Timothy Hatcher]

Comment on attachment 225076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225076&action=review

>> Source/WebInspectorUI/UserInterface/Views/Toolbar.css:58
>> +    background-image: -webkit-linear-gradient(top, rgb(233, 233, 233), rgb(229, 229, 229));
> 
> You could have used the W3C syntax as follows, with the default value for the orientation: linear-gradient(rgb(229, 229, 229), rgb(233, 233, 233));

I fixed all our gradients to use the in prefixed version in a follow up.