Bug 129259 - Subpixel rendering: Ensure consistent border painting width.
Summary: Subpixel rendering: Ensure consistent border painting width.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-24 09:55 PST by zalan
Modified: 2014-02-25 22:18 PST (History)
6 users (show)

See Also:


Attachments
Patch (11.96 KB, patch)
2014-02-24 13:25 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (11.94 KB, patch)
2014-02-25 20:21 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-02-24 09:55:16 PST
class BorderEdge should return width in device pixels so that when the border rect for painting is calculated, the position does not impact border width, in other words, border widths are consistent across edges.
Comment 1 zalan 2014-02-24 11:38:24 PST
(In reply to comment #0)
> class BorderEdge should return width in device pixels so that when the border rect for painting is calculated, the position does not impact border width, in other words, border widths are consistent across edges.

position + fractional border width.
Comment 2 zalan 2014-02-24 13:25:06 PST
Created attachment 225089 [details]
Patch
Comment 3 Simon Fraser (smfr) 2014-02-25 16:57:07 PST
Comment on attachment 225089 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225089&action=review

> Source/WebCore/rendering/RenderBoxModelObject.cpp:1452
> +    float widthForPainting() const { return isPresent ?  flooredToDevicePixelWidth : 0.f; }

Is the .f required?
Comment 4 zalan 2014-02-25 17:37:24 PST
(In reply to comment #3)
> (From update of attachment 225089 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=225089&action=review
> 
> > Source/WebCore/rendering/RenderBoxModelObject.cpp:1452
> > +    float widthForPainting() const { return isPresent ?  flooredToDevicePixelWidth : 0.f; }
> 
> Is the .f required?

Probably just a leftover from my previous attempts. Will remove it before committing. Thanks!
Comment 5 zalan 2014-02-25 20:21:51 PST
Created attachment 225215 [details]
Patch
Comment 6 zalan 2014-02-25 20:22:46 PST
Comment on attachment 225215 [details]
Patch

EWS testing
Comment 7 WebKit Commit Bot 2014-02-25 22:18:56 PST
Comment on attachment 225215 [details]
Patch

Clearing flags on attachment: 225215

Committed r164698: <http://trac.webkit.org/changeset/164698>
Comment 8 WebKit Commit Bot 2014-02-25 22:18:59 PST
All reviewed patches have been landed.  Closing bug.