RESOLVED FIXED 129259
Subpixel rendering: Ensure consistent border painting width.
https://bugs.webkit.org/show_bug.cgi?id=129259
Summary Subpixel rendering: Ensure consistent border painting width.
alan baradlay
Reported 2014-02-24 09:55:16 PST
class BorderEdge should return width in device pixels so that when the border rect for painting is calculated, the position does not impact border width, in other words, border widths are consistent across edges.
Attachments
Patch (11.96 KB, patch)
2014-02-24 13:25 PST, alan baradlay
no flags
Patch (11.94 KB, patch)
2014-02-25 20:21 PST, alan baradlay
no flags
alan baradlay
Comment 1 2014-02-24 11:38:24 PST
(In reply to comment #0) > class BorderEdge should return width in device pixels so that when the border rect for painting is calculated, the position does not impact border width, in other words, border widths are consistent across edges. position + fractional border width.
alan baradlay
Comment 2 2014-02-24 13:25:06 PST
Simon Fraser (smfr)
Comment 3 2014-02-25 16:57:07 PST
Comment on attachment 225089 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225089&action=review > Source/WebCore/rendering/RenderBoxModelObject.cpp:1452 > + float widthForPainting() const { return isPresent ? flooredToDevicePixelWidth : 0.f; } Is the .f required?
alan baradlay
Comment 4 2014-02-25 17:37:24 PST
(In reply to comment #3) > (From update of attachment 225089 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=225089&action=review > > > Source/WebCore/rendering/RenderBoxModelObject.cpp:1452 > > + float widthForPainting() const { return isPresent ? flooredToDevicePixelWidth : 0.f; } > > Is the .f required? Probably just a leftover from my previous attempts. Will remove it before committing. Thanks!
alan baradlay
Comment 5 2014-02-25 20:21:51 PST
alan baradlay
Comment 6 2014-02-25 20:22:46 PST
Comment on attachment 225215 [details] Patch EWS testing
WebKit Commit Bot
Comment 7 2014-02-25 22:18:56 PST
Comment on attachment 225215 [details] Patch Clearing flags on attachment: 225215 Committed r164698: <http://trac.webkit.org/changeset/164698>
WebKit Commit Bot
Comment 8 2014-02-25 22:18:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.