Bug 12925 – PathTraversalState's normalAngleAtLength/pointAtLength don't work.

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Nikolas Zimmermann]

Path::pointAtLength() uses PathTraversalState to iterate through the segments. This comment says it all: "// FIXME: Need to actually find the exact point and change m_current".

For Path::normalAngleAtLength() to work the tangent slope calculation has to be corrected. Attaching patch to fix both.

[Nikolas Zimmermann]

*** Bug 12924 has been marked as a duplicate of this bug. ***

[Nikolas Zimmermann]

Created attachment 13419 [details]
Initial patch

Not marking for review, as it's probably not being accepted in the stabilization spree.

[Nikolas Zimmermann]

Created attachment 13420 [details]
Update patch

Just realized that the pointAtLength() stuff is actally exposed via SVGPathElement's interfaces. We shouldn't release it that buggy - added new LayoutTest covering that these methods actually work. Not a P1, but still marking for review - as it would be annoying to release Safari with that bug.

[Darin Adler]

Comment on attachment 13420 [details]
Update patch

+            static float rad2deg = 180.0 / M_PI;

Really should include "const" in there too.

Is there a way to test this so that the results are numeric instead of visual? If so, I'd love to see a test like that as well as the visual one!

r=me

[Nikolas Zimmermann]

Landed in r19970.