Bug 129243 – AX: AccessibilityObject::findMatchingObjects should never include 'this' in results.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Samuel White]

findMatchingObjects searches children of 'this', it should never be possible for 'this' to be included in results.

[Radar WebKit Bug Importer]

<rdar://problem/16145684>

[Radar WebKit Bug Importer]

<rdar://problem/16145685>

[Samuel White]

Created attachment 225083 [details]
Patch.

Previously, the container object could be included in the search results when searching backwards. This patch removes that and makes forward/backwards results consistent with each other.

[chris fleizach]

Comment on attachment 225083 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=225083&action=review

> LayoutTests/platform/mac/accessibility/search-predicate-container-not-included.html:25
> +        shouldBe("forwardResult", "undefined");

Make sure this works on wk2 as well as wk1

[Samuel White]

(In reply to comment #4)
> (From update of attachment 225083 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=225083&action=review
> 
> > LayoutTests/platform/mac/accessibility/search-predicate-container-not-included.html:25
> > +        shouldBe("forwardResult", "undefined");
> 
> Make sure this works on wk2 as well as wk1

Looks like it doesn't, fixing now.

[Build Bot]

Comment on attachment 225083 [details]
Patch.

Attachment 225083 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5780764994043904

New failing tests:
svg/masking/mask-negative-scale.svg
platform/mac/accessibility/search-predicate-container-not-included.html

[Build Bot]

Created attachment 225091 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Samuel White]

Created attachment 225092 [details]
Updated patch.

Updated test to check the result count instead of the result type to make the test more test harness agnostic.

[WebKit Commit Bot]

Comment on attachment 225092 [details]
Updated patch.

Clearing flags on attachment: 225092

Committed r164616: <http://trac.webkit.org/changeset/164616>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.