Bug 129238 - Extract platform specific parts of telephone number detection
Summary: Extract platform specific parts of telephone number detection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-23 17:22 PST by Sam Weinig
Modified: 2014-02-23 17:29 PST (History)
3 users (show)

See Also:

Attachments
Patch (16.93 KB, patch)
2014-02-23 17:23 PST, Sam Weinig 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2014-02-23 17:22:04 PST 
Extract platform specific parts of telephone number detection
Comment 1 Sam Weinig 2014-02-23 17:23:12 PST 
Created attachment 225019 [details]
Patch
Comment 2 WebKit Commit Bot 2014-02-23 17:24:14 PST 
Attachment 225019 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/TelephoneNumberDetector.h:29:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/platform/TelephoneNumberDetector.h:42:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2014-02-23 17:29:59 PST 
Committed in https://trac.webkit.org/changeset/164569.