WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
129238
Extract platform specific parts of telephone number detection
https://bugs.webkit.org/show_bug.cgi?id=129238
Summary
Extract platform specific parts of telephone number detection
Sam Weinig
Reported
2014-02-23 17:22:04 PST
Extract platform specific parts of telephone number detection
Attachments
Patch
(16.93 KB, patch)
2014-02-23 17:23 PST
,
Sam Weinig
dino
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2014-02-23 17:23:12 PST
Created
attachment 225019
[details]
Patch
WebKit Commit Bot
Comment 2
2014-02-23 17:24:14 PST
Attachment 225019
[details]
did not pass style-queue: ERROR: Source/WebCore/platform/TelephoneNumberDetector.h:29: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebCore/platform/TelephoneNumberDetector.h:42: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3
2014-02-23 17:29:59 PST
Committed in
https://trac.webkit.org/changeset/164569
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug