Bug 129232 - Update ANGLE to 836bd2176e5607b14846cf1fbc5932dbc91318f4
Summary: Update ANGLE to 836bd2176e5607b14846cf1fbc5932dbc91318f4
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-02-23 06:04 PST by Dean Jackson
Modified: 2014-02-23 16:39 PST (History)
16 users (show)

See Also:


Attachments
Patch (3.70 MB, patch)
2014-02-23 06:09 PST, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (3.71 MB, patch)
2014-02-23 07:03 PST, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (3.71 MB, patch)
2014-02-23 07:25 PST, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (3.71 MB, patch)
2014-02-23 07:58 PST, Dean Jackson
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (460.28 KB, application/zip)
2014-02-23 09:09 PST, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (486.63 KB, application/zip)
2014-02-23 09:26 PST, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (456.76 KB, application/zip)
2014-02-23 10:04 PST, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (486.71 KB, application/zip)
2014-02-23 10:29 PST, Build Bot
no flags Details
Patch (3.71 MB, patch)
2014-02-23 14:39 PST, Dean Jackson
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2014-02-23 06:04:27 PST
Update ANGLE, in particular to get a fix for ANGLE bug 554.
Comment 1 Radar WebKit Bug Importer 2014-02-23 06:04:36 PST
<rdar://problem/16143495>
Comment 2 Dean Jackson 2014-02-23 06:09:49 PST
Created attachment 224999 [details]
Patch
Comment 3 Dean Jackson 2014-02-23 06:10:36 PST
Uploading a patch for EWS. The style checker is going to shit a chicken on this. 

I bet some of the ports will fail to build, so expect a few iterations here.
Comment 4 WebKit Commit Bot 2014-02-23 06:15:05 PST
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 5 Dean Jackson 2014-02-23 07:03:05 PST
Created attachment 225000 [details]
Patch
Comment 6 Dean Jackson 2014-02-23 07:25:56 PST
Created attachment 225001 [details]
Patch
Comment 7 Dean Jackson 2014-02-23 07:58:59 PST
Created attachment 225002 [details]
Patch
Comment 8 Dean Jackson 2014-02-23 08:17:07 PST
I need to reapply the max varyings work, and then it should be ready.
Comment 9 Build Bot 2014-02-23 09:09:53 PST
Comment on attachment 225002 [details]
Patch

Attachment 225002 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5680391071465472

New failing tests:
webgl/1.0.2/conformance/glsl/misc/shader-varying-packing-restrictions.html
Comment 10 Build Bot 2014-02-23 09:09:57 PST
Created attachment 225004 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 11 Build Bot 2014-02-23 09:26:41 PST
Comment on attachment 225002 [details]
Patch

Attachment 225002 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6406196923727872

New failing tests:
webgl/1.0.2/conformance/glsl/misc/shader-varying-packing-restrictions.html
Comment 12 Build Bot 2014-02-23 09:26:45 PST
Created attachment 225006 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 13 Build Bot 2014-02-23 10:04:41 PST
Comment on attachment 225002 [details]
Patch

Attachment 225002 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6444848542384128

New failing tests:
webgl/1.0.2/conformance/glsl/misc/shader-varying-packing-restrictions.html
Comment 14 Build Bot 2014-02-23 10:04:49 PST
Created attachment 225007 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 15 Build Bot 2014-02-23 10:29:14 PST
Comment on attachment 225002 [details]
Patch

Attachment 225002 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5934675147096064

New failing tests:
webgl/1.0.2/conformance/glsl/misc/shader-varying-packing-restrictions.html
Comment 16 Build Bot 2014-02-23 10:29:18 PST
Created attachment 225009 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 17 Dean Jackson 2014-02-23 14:39:38 PST
Created attachment 225015 [details]
Patch
Comment 18 Brent Fulgham 2014-02-23 15:38:51 PST
Comment on attachment 225015 [details]
Patch

r=me. It seems to work locally, but we need to keep an eye on the Windows bot after landing.
Comment 19 Dean Jackson 2014-02-23 16:39:35 PST
Committed r164565: <http://trac.webkit.org/changeset/164565>