Bug 129226 - Subpixel rendering: Add subpixel support to border type of double, groove, ridge, inset and outset.
Summary: Subpixel rendering: Add subpixel support to border type of double, groove, ri...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
: 113642 129329 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-02-22 20:53 PST by zalan
Modified: 2015-11-12 13:08 PST (History)
7 users (show)

See Also:

Attachments
Patch (24.57 KB, patch)
2014-02-25 14:57 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (24.66 KB, patch)
2014-02-26 08:19 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (24.69 KB, patch)
2014-02-28 13:26 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-02-22 20:53:05 PST 
Dotted and dashed need GraphicsContext::drawLine() cleanup. There's some odd legacy code there with full of (false) assumptions.
Comment 1 zalan 2014-02-25 14:57:30 PST 
Created attachment 225186 [details]
Patch
Comment 2 zalan 2014-02-26 08:19:39 PST 
Created attachment 225256 [details]
Patch
Comment 3 zalan 2014-02-26 08:20:02 PST 
Comment on attachment 225256 [details]
Patch

EWSing.
Comment 4 Simon Fraser (smfr) 2014-02-26 14:52:31 PST 
Comment on attachment 225256 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225256&action=review

> Source/WebCore/rendering/RenderObject.cpp:738
> +    // FIXME: flooring is a temporary solution until the device pixel snapping is added here for all border types (including recursiveness).

"including recursiveness" is weird.
Comment 5 zalan 2014-02-28 13:26:46 PST 
Created attachment 225485 [details]
Patch
Comment 6 WebKit Commit Bot 2014-02-28 15:00:28 PST 
Comment on attachment 225485 [details]
Patch

Clearing flags on attachment: 225485

Committed r164888: <http://trac.webkit.org/changeset/164888>
Comment 7 WebKit Commit Bot 2014-02-28 15:00:32 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 zalan 2014-03-05 09:38:22 PST 
*** Bug 129329 has been marked as a duplicate of this bug. ***
Comment 9 Joseph Pecoraro 2015-11-12 13:08:39 PST 
*** Bug 113642 has been marked as a duplicate of this bug. ***