RESOLVED FIXED 129220
Remove some unreachable code (-Wunreachable-code) 
https://bugs.webkit.org/show_bug.cgi?id=129220
Summary Remove some unreachable code (-Wunreachable-code)
Joseph Pecoraro
Reported 2014-02-22 16:51:22 PST
Remove some straightforward cases of unreachable code. I believe these are all break statements that have a return, goto, or another break immediately preceding them. It may not be possible to enable -Wunreachable-code by default. There are many places where we have code after CRASH() / NO_RETURN functions, return values after switches that return for all possible values, code that compiles differently on 32/64bit that statically eliminate branches (if sizeof(...)), debug only code enabled/disabled by static booleans that are false, and more. I did file some bugs on real cases of unreachable code that this caught; nothing significant.
Attachments
[PATCH] Proposed Fix (9.64 KB, patch)
2014-02-22 16:53 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2014-02-22 16:53:52 PST
Created attachment 224985 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 2 2014-02-22 17:32:45 PST
Comment on attachment 224985 [details] [PATCH] Proposed Fix Clearing flags on attachment: 224985 Committed r164553: <http://trac.webkit.org/changeset/164553>
WebKit Commit Bot
Comment 3 2014-02-22 17:32:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.