Bug 12920 - Links inserted at the beginning of the document
Summary: Links inserted at the beginning of the document
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 523.x (Safari 3)
Hardware: Macintosh OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 7712 10165
  Show dependency treegraph
 
Reported: 2007-02-27 18:23 PST by Justin Garcia
Modified: 2007-05-14 15:00 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Garcia 2007-02-27 18:23:10 PST
Login to GoogleDocs or Vox (see 7712 and 10165 for GoogleDocs and Vox login instructions, respectively)
Type a words
Click on the Insert Link button in the toolbar
Fill out the required fields, hit OK

The link is inserted at the beginning of the document.  Doesn't happen with GMail's editor.
Comment 1 Justin Garcia 2007-02-27 19:04:12 PST
Here's what happens:

When you click on the Insert Link toolbar button, an ajax dialog pops up for link creation and a form field inside it gains focus.  When a form field is focused, no other element on the page can be focused, so the editable region in the page behind the dialog is blurred.  This blows its selection away.  When the user is finished and the dialog closes, the editable subframe becomes first responder, and setSelectionFromNone gives it a caret at its beginning.

Adele, we should obviously continue to blur focused nodes when a new node gains focus, but could we leave an inactive selection inside the old focused node in the special case where the old focused node is in a different document than the new focused node in order to fix this bug?  Eventually, all blurred elements should remember their selections and restore them when they regain focus, like FF, I think.
Comment 2 Adele Peterson 2007-02-27 22:25:53 PST
I completely agree that we need to be able to restore selection for all editable elements.  We even have some comments in the code about this... (I think in one of the focus() methods).

Right now we have special code to do this just for text fields and textareas (in RenderTextControl).

Who should be in charge of keeping track of the old selection?  An element that's an editable root?  Or documents could keep track of this... which would really only be useful for editors that use editable frames.

Comment 3 Justin Garcia 2007-05-14 15:00:27 PDT
r21467