Bug 129195 - REGRESSION(r164412): Pixel cracks when zooming in to any web content.
Summary: REGRESSION(r164412): Pixel cracks when zooming in to any web content.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2014-02-21 21:22 PST by zalan
Modified: 2014-02-21 23:19 PST (History)
7 users (show)

See Also:

Attachments
Patch (3.03 KB, patch)
2014-02-21 21:40 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (4.87 KB, patch)
2014-02-21 22:38 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-02-21 21:22:51 PST 
1. Load any web page.
2. Pinch-zoom in.
3. 1 pixel width tile grid shows up.
Comment 1 zalan 2014-02-21 21:23:38 PST 
<rdar://problem/16131028>
Comment 2 zalan 2014-02-21 21:40:05 PST 
Created attachment 224946 [details]
Patch
Comment 3 Simon Fraser (smfr) 2014-02-21 22:18:04 PST 
Comment on attachment 224946 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224946&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:2243
> +    LayoutRect dirtyRect(enclosingIntRect(clip));
>      IntRect pixelSnappedRectForIntegralPositionedItems = pixelSnappedIntRect(dirtyRect);

Odd that you call pixelSnappedIntRect() on the result of enclosingIntRect(). Should it be an IntRect?
Comment 4 zalan 2014-02-21 22:23:10 PST 
(In reply to comment #3)
> (From update of attachment 224946 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=224946&action=review
> 
> > Source/WebCore/rendering/RenderLayerBacking.cpp:2243
> > +    LayoutRect dirtyRect(enclosingIntRect(clip));
> >      IntRect pixelSnappedRectForIntegralPositionedItems = pixelSnappedIntRect(dirtyRect);
> 
> Odd that you call pixelSnappedIntRect() on the result of enclosingIntRect(). Should it be an IntRect?
Yes, it looks odd, but I left it there so that when I clean up the paint rect clipping all I need to change back is the dirtyRect and the pixelSnappedRectForIntegralPositionedItems can stay as it is.
Comment 5 zalan 2014-02-21 22:26:24 PST 
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 224946 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=224946&action=review
> > 
> > > Source/WebCore/rendering/RenderLayerBacking.cpp:2243
> > > +    LayoutRect dirtyRect(enclosingIntRect(clip));
> > >      IntRect pixelSnappedRectForIntegralPositionedItems = pixelSnappedIntRect(dirtyRect);
> > 
> > Odd that you call pixelSnappedIntRect() on the result of enclosingIntRect(). Should it be an IntRect?
> Yes, it looks odd, but I left it there so that when I clean up the paint rect clipping all I need to change back is the dirtyRect and the pixelSnappedRectForIntegralPositionedItems can stay as it is.

I guess I should remove it to not to cause any confusion. (as it might take a few days to get to the clipping cleanup)
Comment 6 Simon Fraser (smfr) 2014-02-21 22:29:57 PST 
Just add a comment if you plan to come back to it.
Comment 7 zalan 2014-02-21 22:38:24 PST 
Created attachment 224948 [details]
Patch
Comment 8 zalan 2014-02-21 22:38:52 PST 
Comment on attachment 224948 [details]
Patch

EWSing.
Comment 9 zalan 2014-02-21 22:40:17 PST 
(In reply to comment #6)
> Just add a comment if you plan to come back to it.
I prefer what you suggested first. It's more explicit that way. Thanks for the review.
Comment 10 WebKit Commit Bot 2014-02-21 23:19:24 PST 
Comment on attachment 224948 [details]
Patch

Clearing flags on attachment: 224948

Committed r164532: <http://trac.webkit.org/changeset/164532>
Comment 11 WebKit Commit Bot 2014-02-21 23:19:27 PST 
All reviewed patches have been landed.  Closing bug.