Bug 129185 - Web Inspector: Remove WebInspector.EventHandler in favor of WebInspector.EventListenerSet
Summary: Web Inspector: Remove WebInspector.EventHandler in favor of WebInspector.Even...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2014-02-21 17:03 PST by Timothy Hatcher
Modified: 2014-03-04 08:26 PST (History)
5 users (show)

See Also:

Patch (6.09 KB, patch)
2014-03-03 15:38 PST, Diego Pino
no flags Details | Formatted Diff | Diff
Patch (6.14 KB, patch)
2014-03-03 22:58 PST, Diego Pino
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2014-02-21 17:03:46 PST
We have two similar classes, WebInspector.EventHandler and WebInspector.EventListenerSet. We should just remove the one client of WebInspector.EventHandler and replace it with WebInspector.EventListenerSet or vanilla listeners.
Comment 1 Radar WebKit Bug Importer 2014-02-21 17:04:25 PST
Comment 2 Diego Pino 2014-03-03 15:38:06 PST
Created attachment 225701 [details]
Comment 3 Timothy Hatcher 2014-03-03 15:39:55 PST
Comment on attachment 225701 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=225701&action=review

> Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:1258
> +            this._popoverEventHandler = new WebInspector.EventListenerSet(this, "Popover listeners");

This should be called _popoverEventListeners or _popoverEventListenerSet to match the class name better.
Comment 4 Diego Pino 2014-03-03 22:58:48 PST
Created attachment 225743 [details]
Comment 5 WebKit Commit Bot 2014-03-04 08:26:39 PST
Comment on attachment 225743 [details]

Clearing flags on attachment: 225743

Committed r165052: <http://trac.webkit.org/changeset/165052>
Comment 6 WebKit Commit Bot 2014-03-04 08:26:41 PST
All reviewed patches have been landed.  Closing bug.