Spec states that:
- iceServers should not be an empty list
- the entry in the configuration dictionary is "urls", instead of "url"
- urls can be either a list or a string
Fixing all that in RTCConfiguration validation when creating a RTCPeerConnection
Created attachment 224926 [details]
Comment on attachment 224926 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=224926&action=review
I might have missed it, but I don't see any new tests that pass a list of urls.
> + // Spec says that "urls" can be either a string or a sequence, so we must check for both.
> + Vector<String> urlsList;
> + String urlString;
Nit: this can move down where the variables are used.
Created attachment 225080 [details]
Comment on attachment 225080 [details]
Clearing flags on attachment: 225080
Committed r164602: <http://trac.webkit.org/changeset/164602>