Bug 129177 – Replace svg/clip-path pixel tests by reference tests

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Dirk Schulze]

We got some regressions on SVG clip-path tests. To detect regressions earlier I will replace all clip-path pixel tests with ref tests.

[Dirk Schulze]

Created attachment 224917 [details]
Patch - removes all pixel tests and pixel results

[Dirk Schulze]

Created attachment 224919 [details]
New reference tests

[Dirk Schulze]

Created attachment 224920 [details]
New reference tests

Without change log. Will add change log on landing.

[Dirk Schulze]

Created attachment 224924 [details]
New reference tests

[WebKit Commit Bot]

Attachment 224924 [details] did not pass style-queue:


ERROR: LayoutTests/platform/mac/TestExpectations:1339:  Line contains tab character.  [whitespace/tab] [5]
ERROR: LayoutTests/platform/gtk/TestExpectations:1552:  Line contains tab character.  [whitespace/tab] [5]
ERROR: LayoutTests/platform/win/TestExpectations:2808:  Line contains tab character.  [whitespace/tab] [5]
ERROR: LayoutTests/platform/efl/TestExpectations:1871:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 4 in 133 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dean Jackson]

Comment on attachment 224924 [details]
New reference tests

r+ from me once you fix style errors.

[Dirk Schulze]

Created attachment 224947 [details]
Upload new tests

Upload new tests. Remove pixel tests in 2nd step.

[Ryosuke Niwa]

Comment on attachment 224917 [details]
Patch - removes all pixel tests and pixel results

rs=me

[WebKit Commit Bot]

Comment on attachment 224947 [details]
Upload new tests

Clearing flags on attachment: 224947

Committed r164531: <http://trac.webkit.org/changeset/164531>

[Dirk Schulze]

Created attachment 224951 [details]
Remove pixel tests

Remove pixel tests

[WebKit Commit Bot]

Comment on attachment 224951 [details]
Remove pixel tests

Rejecting attachment 224951 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 224951, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ask-path-and-image-based-clipping.svg'
patching file LayoutTests/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt
rm 'LayoutTests/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt'
patching file LayoutTests/svg/clip-path/nested-clip-in-mask-path-based-clipping.svg
rm 'LayoutTests/svg/clip-path/nested-clip-in-mask-path-based-clipping.svg'

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/4622606527365120

[Dirk Schulze]

Committed r164539: <http://trac.webkit.org/changeset/164539>