Bug 129161 – Add a supportsKeySystem media engine factory parameter.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

Add a supportsKeySystem media engine factory parameter.

[Jer Noble]

Created attachment 224891 [details]
Patch

[WebKit Commit Bot]

Attachment 224891 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/MediaPlayer.cpp:176:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Carlson]

Comment on attachment 224891 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224891&action=review

If the registrar took a MediaPlayerFactory instead of a bunch of function pointers, we could add new factory methods without touching ports that don't implement them. 

r=me either way.

> Source/WebCore/platform/graphics/MediaPlayer.cpp:1020
> +    unsigned size = engines.size();
> +    for (unsigned i = 0; i < size; i++) {
> +        if (engines[i]->supportsKeySystem && engines[i]->supportsKeySystem(keySystem, mimeType))
> +            return true;
> +    }

Can this use a range-based loop?

[Jer Noble]

Created attachment 224913 [details]
Patch for landing

[WebKit Commit Bot]

Attachment 224913 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/MediaPlayer.cpp:176:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jer Noble]

Committed r164513: <http://trac.webkit.org/changeset/164513>