Bug 129144 - Disallow the use of -webkit-user-modify on shadow pseudo elements
Summary: Disallow the use of -webkit-user-modify on shadow pseudo elements
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
Depends on:
Blocks: 129034
  Show dependency treegraph
Reported: 2014-02-21 01:47 PST by Ryosuke Niwa
Modified: 2014-02-21 14:27 PST (History)
14 users (show)

See Also:

Patch (10.69 KB, patch)
2014-02-21 01:52 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2014-02-21 01:47:29 PST
It's a terrible idea to let authors override the editability of UA shadow DOM via -webkit-user-modify.
In fact, we already have a bunch of -webkit-user-modify: read-only !important rules in html.css.

In order to resolve the bug 129034, completely disallow them in all cases in the engine itself.

Heck, we probably want to disallow -webkit-user-modify anywhere in the shadow DOM since it's a legacy CSS property
that's hurting the performance for us.
Comment 1 Ryosuke Niwa 2014-02-21 01:52:09 PST
Created attachment 224843 [details]
Comment 2 Geoffrey Garen 2014-02-21 13:55:50 PST
Comment on attachment 224843 [details]

Comment 3 WebKit Commit Bot 2014-02-21 14:27:54 PST
Comment on attachment 224843 [details]

Clearing flags on attachment: 224843

Committed r164501: <http://trac.webkit.org/changeset/164501>
Comment 4 WebKit Commit Bot 2014-02-21 14:27:57 PST
All reviewed patches have been landed.  Closing bug.