Bug 129135 - ASSERT on touches callbacks after r164409 on iOS
Summary: ASSERT on touches callbacks after r164409 on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-20 17:55 PST by Enrica Casucci
Modified: 2017-06-22 18:49 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.84 KB, patch)
2014-02-20 17:58 PST, Enrica Casucci 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2014-02-20 17:55:35 PST 
http://trac.webkit.org/changeset/164409 caused a number of ASSERT to fire on iOS.
true was used in the call to m_performCallbackWithReturnValue (instead of false) and false in invalidate (instead of true).
This change also reintroduced the use of isMainThread on WebKit2 which doesn't work on iOS and should replaced with RunLoop::isMain().
Comment 1 Enrica Casucci 2014-02-20 17:58:28 PST 
Created attachment 224814 [details]
Patch
Comment 2 Enrica Casucci 2014-02-20 18:08:55 PST 
Committed revision 164462.