Bug 129126 - Move the image controls setting to Settings.in
Summary: Move the image controls setting to Settings.in
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-20 15:56 PST by Brady Eidson
Modified: 2014-02-20 17:09 PST (History)
2 users (show)

See Also:


Attachments
Patch v1 (2.28 KB, patch)
2014-02-20 15:57 PST, Brady Eidson
thorton: review+
beidson: commit-queue-
Details | Formatted Diff | Diff
Patch for landing. (2.99 KB, patch)
2014-02-20 16:32 PST, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-02-20 15:56:08 PST
Move the image controls setting to Settings.in
Comment 1 Brady Eidson 2014-02-20 15:57:21 PST
Created attachment 224807 [details]
Patch v1
Comment 2 Tim Horton 2014-02-20 16:08:33 PST
Comment on attachment 224807 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=224807&action=review

> Source/WebCore/page/Settings.h:-242
> -    bool imageControlsEnabled() { return m_imageControlsEnabled; }

do you still need the member and its initializer? I don't see them for other Settings.in settings...
Comment 3 Brady Eidson 2014-02-20 16:32:50 PST
Created attachment 224808 [details]
Patch for landing.
Comment 4 WebKit Commit Bot 2014-02-20 17:09:17 PST
Comment on attachment 224808 [details]
Patch for landing.

Clearing flags on attachment: 224808

Committed r164458: <http://trac.webkit.org/changeset/164458>
Comment 5 WebKit Commit Bot 2014-02-20 17:09:19 PST
All reviewed patches have been landed.  Closing bug.