RESOLVED FIXED 129126
Move the image controls setting to Settings.in 
https://bugs.webkit.org/show_bug.cgi?id=129126
Summary Move the image controls setting to Settings.in
Brady Eidson
Reported 2014-02-20 15:56:08 PST
Move the image controls setting to Settings.in
Attachments
Patch v1 (2.28 KB, patch)
2014-02-20 15:57 PST, Brady Eidson 		thorton: review+
beidson: commit-queue-
DetailsFormatted DiffDiff
Patch for landing. (2.99 KB, patch)
2014-02-20 16:32 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2014-02-20 15:57:21 PST
Created attachment 224807 [details] Patch v1
Tim Horton
Comment 2 2014-02-20 16:08:33 PST
Comment on attachment 224807 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=224807&action=review > Source/WebCore/page/Settings.h:-242 > - bool imageControlsEnabled() { return m_imageControlsEnabled; } do you still need the member and its initializer? I don't see them for other Settings.in settings...
Brady Eidson
Comment 3 2014-02-20 16:32:50 PST
Created attachment 224808 [details] Patch for landing.
WebKit Commit Bot
Comment 4 2014-02-20 17:09:17 PST
Comment on attachment 224808 [details] Patch for landing. Clearing flags on attachment: 224808 Committed r164458: <http://trac.webkit.org/changeset/164458>
WebKit Commit Bot
Comment 5 2014-02-20 17:09:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.