Bug 129106 - [GTK] Regression when showing the captions menu
Summary: [GTK] Regression when showing the captions menu
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-20 09:33 PST by Xabier Rodríguez Calvar
Modified: 2014-02-26 01:36 PST (History)
7 users (show)

See Also:


Attachments
Patch (5.86 KB, patch)
2014-02-20 09:37 PST, Xabier Rodríguez Calvar
no flags Details | Formatted Diff | Diff
Patch (4.36 KB, patch)
2014-02-24 02:36 PST, Xabier Rodríguez Calvar
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2014-02-20 09:33:09 PST
[GTK] Regression when showing the captions menu
Comment 1 Xabier Rodríguez Calvar 2014-02-20 09:37:08 PST
Created attachment 224762 [details]
Patch
Comment 2 Martin Robinson 2014-02-20 09:51:12 PST
Comment on attachment 224762 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224762&action=review

> LayoutTests/media/video-controls-captions-trackmenu-show-properly.html:31
> +        <p>Test that we are able to trigger the list of captions with
> +        it showing properly .</p>

Could this check be combined into some other test that looks at properties of the track list?
Comment 3 Xabier Rodríguez Calvar 2014-02-20 10:33:59 PST
(In reply to comment #2)
> > LayoutTests/media/video-controls-captions-trackmenu-show-properly.html:31
> > +        <p>Test that we are able to trigger the list of captions with
> > +        it showing properly .</p>
> 
> Could this check be combined into some other test that looks at properties of the track list?

I guess it could, but some of them are skipped because of the new controls, which fail for other reasons, also in Apple.
Comment 4 Xabier Rodríguez Calvar 2014-02-24 02:36:17 PST
Created attachment 225048 [details]
Patch

I removed the test and added that part of the code to one of the tests. The problem is that all trackmenu tests are flagged in Mac and GTK+, so this regression won't be properly tested unless we go for the other version with the complete test, which I think it is not bad idea because at lest a very basic functionaly of the menu is tested.
Comment 5 Martin Robinson 2014-02-25 10:11:54 PST
Comment on attachment 225048 [details]
Patch

Okay. This fix seems obvious, but we really need to have the trackmenu tests unskipped. :/
Comment 6 WebKit Commit Bot 2014-02-26 01:36:14 PST
Comment on attachment 225048 [details]
Patch

Clearing flags on attachment: 225048

Committed r164711: <http://trac.webkit.org/changeset/164711>
Comment 7 WebKit Commit Bot 2014-02-26 01:36:17 PST
All reviewed patches have been landed.  Closing bug.