Bug 129106 – [GTK] Regression when showing the captions menu

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Xabier Rodríguez Calvar]

[GTK] Regression when showing the captions menu

[Xabier Rodríguez Calvar]

Created attachment 224762 [details]
Patch

[Martin Robinson]

Comment on attachment 224762 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224762&action=review

> LayoutTests/media/video-controls-captions-trackmenu-show-properly.html:31
> +        <p>Test that we are able to trigger the list of captions with
> +        it showing properly .</p>

Could this check be combined into some other test that looks at properties of the track list?

[Xabier Rodríguez Calvar]

(In reply to comment #2)
> > LayoutTests/media/video-controls-captions-trackmenu-show-properly.html:31
> > +        <p>Test that we are able to trigger the list of captions with
> > +        it showing properly .</p>
> 
> Could this check be combined into some other test that looks at properties of the track list?

I guess it could, but some of them are skipped because of the new controls, which fail for other reasons, also in Apple.

[Xabier Rodríguez Calvar]

Created attachment 225048 [details]
Patch

I removed the test and added that part of the code to one of the tests. The problem is that all trackmenu tests are flagged in Mac and GTK+, so this regression won't be properly tested unless we go for the other version with the complete test, which I think it is not bad idea because at lest a very basic functionaly of the menu is tested.

[Martin Robinson]

Comment on attachment 225048 [details]
Patch

Okay. This fix seems obvious, but we really need to have the trackmenu tests unskipped. :/

[WebKit Commit Bot]

Comment on attachment 225048 [details]
Patch

Clearing flags on attachment: 225048

Committed r164711: <http://trac.webkit.org/changeset/164711>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.