Bug 129088 - Web Inspector: Popover should animate its frame to display its refreshed content
Summary: Web Inspector: Popover should animate its frame to display its refreshed content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks: 119686
  Show dependency tree / graph
 
Reported: 2014-02-20 01:33 PST by Antoine Quint
Modified: 2014-02-20 09:22 PST (History)
5 users (show)

See Also:

Attachments
Patch (16.13 KB, patch)
2014-02-20 01:55 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2014-02-20 01:33:18 PST 
The Popover.prototype.update() method allows for a popover to recompute and redraw its frame to accommodate a change within the DOM node set as its .content, but that update is discrete. In many situations, the edge the popover attaches to the target frame is unchanged and thus it should be possible to animate the popover frame for a more pleasing transition of content.
Comment 1 Radar WebKit Bug Importer 2014-02-20 01:33:34 PST 
<rdar://problem/16119649>
Comment 2 Antoine Quint 2014-02-20 01:35:37 PST 
Necessary to land https://bugs.webkit.org/show_bug.cgi?id=119686.
Comment 3 Antoine Quint 2014-02-20 01:55:29 PST 
Created attachment 224733 [details]
Patch
Comment 4 WebKit Commit Bot 2014-02-20 09:21:59 PST 
Comment on attachment 224733 [details]
Patch

Clearing flags on attachment: 224733

Committed r164432: <http://trac.webkit.org/changeset/164432>
Comment 5 WebKit Commit Bot 2014-02-20 09:22:01 PST 
All reviewed patches have been landed.  Closing bug.