Bug 129075 - RenderBox::updateShapeOutsideInfoAfterStyleChange shows up on profiles
Summary: RenderBox::updateShapeOutsideInfoAfterStyleChange shows up on profiles
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-19 16:46 PST by Simon Fraser (smfr)
Modified: 2014-02-20 21:56 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.47 KB, patch)
2014-02-19 16:58 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-02-19 16:46:20 PST 
updateShapeOutsideInfoAfterStyleChange should never show up on profiles if shapes are not being used. We need to make sure it doesn't impact perf. I was seeing it as 0.3% of time.
Comment 1 Simon Fraser (smfr) 2014-02-19 16:58:59 PST 
Created attachment 224693 [details]
Patch
Comment 2 Bear Travis 2014-02-20 10:50:00 PST 
Seems fine to me. It looks like Shape Inside may suffer from a similar concern with RenderBlock::updateShapeInsideInfoAfterStyleChange. I can fix that up after this lands.
Comment 3 WebKit Commit Bot 2014-02-20 21:56:55 PST 
Comment on attachment 224693 [details]
Patch

Clearing flags on attachment: 224693

Committed r164471: <http://trac.webkit.org/changeset/164471>
Comment 4 WebKit Commit Bot 2014-02-20 21:56:57 PST 
All reviewed patches have been landed.  Closing bug.