[UI-Side Compositing] 6% of main thread time spent copying LayerProperties when adding to hash table
<rdar://problem/15741031>
Created attachment 224691 [details] Patch
Comment on attachment 224691 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224691&action=review > Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:214 > if (changedProperties & BackingStoreChanged) { > - encoder << backingStore.hasFrontBuffer(); > - if (backingStore.hasFrontBuffer()) > - encoder << backingStore; > + encoder << backingStore->hasFrontBuffer(); > + if (backingStore->hasFrontBuffer()) > + encoder << *backingStore; > } What if BackingStoreChanged because it went away?? I guess we'll still have one, it'll just be one that doesn't paint.
https://trac.webkit.org/r164405
Looks like this was ~1.5% performance improvement on DoYouEvenBench: https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mavericks%22%2C%22DoYouEvenBench%2FFull%3ATime%3ATotal%22%5D%5D
(In reply to comment #5) > Looks like this was ~1.5% performance improvement on DoYouEvenBench: > https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mavericks%22%2C%22DoYouEvenBench%2FFull%3ATime%3ATotal%22%5D%5D That would be a bit concerning, as this code isn't used at all on Mac at the moment.
(In reply to comment #6) > (In reply to comment #5) > > Looks like this was ~1.5% performance improvement on DoYouEvenBench: > > https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mavericks%22%2C%22DoYouEvenBench%2FFull%3ATime%3ATotal%22%5D%5D > > That would be a bit concerning, as this code isn't used at all on Mac at the moment. Okay. It's probably http://trac.webkit.org/changeset/164401 then.