Bug 129068 – fieldset:disabled > legend:first-child legend input should not be disabled

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Ryosuke Niwa]

Input elements inside the first legend element of a disabled fieldset should not be disabled
even if it's inside another legend element as long as the input element itself is not disabled.

[Ryosuke Niwa]

Created attachment 224688 [details]
Fixes the bug

[Andreas Kling]

Comment on attachment 224688 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=224688&action=review

r=me

> Source/WebCore/ChangeLog:9
> +        An input element inside a disabled fieldset element is ordinarily disabled unless it's inside
> +        a legend element that is the first of its kind to appear in the fieldset's child node list.

It would be interesting to note what other engines do in this scenario.

> Source/WebCore/ChangeLog:11
> +        Prior to this pach, an input element inside such a legend element was erroneously disabled if

patch

> Source/WebCore/html/HTMLFormControlElement.cpp:104
> +    Element* previousAncestor = 0;

nullptr

> Source/WebCore/html/HTMLFormControlElement.cpp:106
>          if (ancestor->hasTagName(fieldsetTag)) {

isHTMLFieldSetElement(ancestor)

> Source/WebCore/html/HTMLFormControlElement.cpp:107
> +            HTMLFieldSetElement* fieldSetAncestor = toHTMLFieldSetElement(ancestor);

I would make this a reference.

> Source/WebCore/html/HTMLFormControlElement.cpp:108
> +            bool isInFirstLegend = previousAncestor && previousAncestor->hasTagName(legendTag) && previousAncestor == fieldSetAncestor->legend();

isHTMLLegendElement(previousAncestor)

[Ryosuke Niwa]

Committed r164403: <http://trac.webkit.org/changeset/164403>