Bug 129059 - WKInteractionView always blocks the main thread when sending touch events
Summary: WKInteractionView always blocks the main thread when sending touch events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-19 13:52 PST by Benjamin Poulain
Modified: 2014-02-20 21:18 PST (History)
2 users (show)

See Also:


Attachments
Patch (17.48 KB, patch)
2014-02-19 13:54 PST, Benjamin Poulain
enrica: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-02-19 13:52:50 PST
WKInteractionView always block the main thread when sending touch events
Comment 1 Benjamin Poulain 2014-02-19 13:54:05 PST
Created attachment 224670 [details]
Patch
Comment 2 Enrica Casucci 2014-02-20 15:38:11 PST
Comment on attachment 224670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224670&action=review

Looks good to me.

> Source/WebKit2/ChangeLog:3
> +        WKInteractionView always block the main thread when sending touch events

typo blocks

> Source/WebKit2/UIProcess/API/ios/WKInteractionView.mm:152
> +    unsigned _nativeWebTouchEventUniqueIdBeingSendSynchronously;

I think the name should be _nativeWebTouchEventUniqueIdBeingSentSynchronously
Comment 3 Benjamin Poulain 2014-02-20 21:18:05 PST
Committed r164469: <http://trac.webkit.org/changeset/164469>