WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
129031
[cmake] *Names.cpp file should be regenerated after touching StaticString.pm
https://bugs.webkit.org/show_bug.cgi?id=129031
Summary
[cmake] *Names.cpp file should be regenerated after touching StaticString.pm
Csaba Osztrogonác
Reported
2014-02-18 23:25:59 PST
This bug was revealed by
http://trac.webkit.org/changeset/164347
which broke the build on the EWS and buildbots too. Because of this build system bug, triggering clean build manually needed.
Attachments
Patch
(1003 bytes, patch)
2014-02-19 00:04 PST
,
Csaba Osztrogonác
no flags
Details
Formatted Diff
Diff
Patch
(3.19 KB, patch)
2014-02-28 06:51 PST
,
Berta József
no flags
Details
Formatted Diff
Diff
Patch
(3.20 KB, patch)
2014-02-28 07:54 PST
,
Berta József
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1
2014-02-19 00:04:38 PST
Created
attachment 224601
[details]
Patch kick EFL EWS bots to regenerate *Names.cpp now
Gyuyoung Kim
Comment 2
2014-02-19 03:25:32 PST
(In reply to
comment #1
)
> Created an attachment (id=224601) [details] > Patch > > kick EFL EWS bots to regenerate *Names.cpp now
Thanks a lot !
Berta József
Comment 3
2014-02-28 06:51:34 PST
Created
attachment 225458
[details]
Patch Calling make_names.pm dependencies to regenerate *Names.cpp files.
WebKit Commit Bot
Comment 4
2014-02-28 06:53:54 PST
Attachment 225458
[details]
did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Berta József
Comment 5
2014-02-28 07:54:10 PST
Created
attachment 225463
[details]
Patch Correcting changelog
WebKit Commit Bot
Comment 6
2014-03-03 02:10:18 PST
Comment on
attachment 225463
[details]
Patch Clearing flags on attachment: 225463 Committed
r164979
: <
http://trac.webkit.org/changeset/164979
>
WebKit Commit Bot
Comment 7
2014-03-03 02:10:23 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug