Bug 129031 - [cmake] *Names.cpp file should be regenerated after touching StaticString.pm
Summary: [cmake] *Names.cpp file should be regenerated after touching StaticString.pm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Critical
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-18 23:25 PST by Csaba Osztrogonác
Modified: 2014-03-03 02:10 PST (History)
10 users (show)

See Also:

Attachments
Patch (1003 bytes, patch)
2014-02-19 00:04 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Patch (3.19 KB, patch)
2014-02-28 06:51 PST, Berta József 		no flags Details | Formatted Diff | Diff
Patch (3.20 KB, patch)
2014-02-28 07:54 PST, Berta József 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2014-02-18 23:25:59 PST 
This bug was revealed by http://trac.webkit.org/changeset/164347
which broke the build on the EWS and buildbots too. Because of
this build system bug, triggering clean build manually needed.
Comment 1 Csaba Osztrogonác 2014-02-19 00:04:38 PST 
Created attachment 224601 [details]
Patch

kick EFL EWS bots to regenerate *Names.cpp now
Comment 2 Gyuyoung Kim 2014-02-19 03:25:32 PST 
(In reply to comment #1)
> Created an attachment (id=224601) [details]
> Patch
> 
> kick EFL EWS bots to regenerate *Names.cpp now

Thanks a lot !
Comment 3 Berta József 2014-02-28 06:51:34 PST 
Created attachment 225458 [details]
Patch

Calling make_names.pm dependencies to regenerate *Names.cpp files.
Comment 4 WebKit Commit Bot 2014-02-28 06:53:54 PST 
Attachment 225458 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Berta József 2014-02-28 07:54:10 PST 
Created attachment 225463 [details]
Patch

Correcting changelog
Comment 6 WebKit Commit Bot 2014-03-03 02:10:18 PST 
Comment on attachment 225463 [details]
Patch

Clearing flags on attachment: 225463

Committed r164979: <http://trac.webkit.org/changeset/164979>
Comment 7 WebKit Commit Bot 2014-03-03 02:10:23 PST 
All reviewed patches have been landed.  Closing bug.