Bug 129029 - Simplify PLATFORM(MAC) && !PLATFORM(IOS) and similar expressions
Summary: Simplify PLATFORM(MAC) && !PLATFORM(IOS) and similar expressions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-18 22:54 PST by mitz
Modified: 2014-02-19 00:07 PST (History)
3 users (show)

See Also:

Attachments
Remove redundant !PLATFORM(IOS) (70.87 KB, patch)
2014-02-18 22:56 PST, mitz 		mrowe: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-02-18 22:54:16 PST 
Simplify PLATFORM(MAC) && !PLATFORM(IOS) and similar expressions
Comment 1 mitz 2014-02-18 22:56:38 PST 
Created attachment 224597 [details]
Remove redundant !PLATFORM(IOS)
Comment 2 WebKit Commit Bot 2014-02-18 22:59:50 PST 
Attachment 224597 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 77 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Rowe (bdash) 2014-02-19 00:04:15 PST 
Comment on attachment 224597 [details]
Remove redundant !PLATFORM(IOS)

View in context: https://bugs.webkit.org/attachment.cgi?id=224597&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

The style bot thinks you should remove this.
Comment 4 mitz 2014-02-19 00:07:20 PST 
Committed <http://trac.webkit.org/r164358>.