Bug 129022 - Add FeatureDefines for image controls
Summary: Add FeatureDefines for image controls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 129028
  Show dependency treegraph
 
Reported: 2014-02-18 20:37 PST by Brady Eidson
Modified: 2014-02-19 11:12 PST (History)
3 users (show)

See Also:


Attachments
Patch v1 (29.03 KB, patch)
2014-02-18 20:45 PST, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-02-18 20:37:43 PST
Add FeatureDefines for image controls

Image controls will be platform-specific UI on top of images.  To help with development that requires constant rolling-in and rolling-out of patches, it'll be a big help to land the feature defines separately.
Comment 1 Brady Eidson 2014-02-18 20:45:02 PST
Created attachment 224582 [details]
Patch v1
Comment 2 WebKit Commit Bot 2014-02-19 09:30:34 PST
Comment on attachment 224582 [details]
Patch v1

Clearing flags on attachment: 224582

Committed r164366: <http://trac.webkit.org/changeset/164366>
Comment 3 WebKit Commit Bot 2014-02-19 09:30:35 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Joseph Pecoraro 2014-02-19 11:12:18 PST
Comment on attachment 224582 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=224582&action=review

> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:96
> +ENABLE_IMAGE_CONTROLS_macosx_1080 = ;
> +ENABLE_IMAGE_CONTROLS_macosx_1090 = ;
> +ENABLE_IMAGE_CONTROLS_macosx_101000 = ENABLE_IMAGE_CONTROLS;

I wonder why we include 1080 and 1090 if the feature is not enabled there. We could just leave them off right?