Bug 129016 - Clean up WKContentView initialization
Summary: Clean up WKContentView initialization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-18 18:32 PST by Simon Fraser (smfr)
Modified: 2014-02-18 20:07 PST (History)
1 user (show)

See Also:


Attachments
Patch (5.94 KB, patch)
2014-02-18 18:34 PST, Simon Fraser (smfr)
benjamin: review+
benjamin: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-02-18 18:32:37 PST
Clean up WKContentView initialization
Comment 1 Simon Fraser (smfr) 2014-02-18 18:34:15 PST
Created attachment 224575 [details]
Patch
Comment 2 Benjamin Poulain 2014-02-18 18:37:02 PST
Comment on attachment 224575 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224575&action=review

> Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:246
> -    _contentView = adoptNS([[WKContentView alloc] initWithFrame:bounds contextRef:contextRef pageGroupRef:pageGroupRef relatedToPage:relatedPage]);
> +    WebKit::WebPageConfiguration webPageConfiguration;
> +    webPageConfiguration.pageGroup = toImpl(pageGroupRef);
> +    webPageConfiguration.relatedPage = toImpl(relatedPage);
> +
> +    _contentView = adoptNS([[WKContentView alloc] initWithFrame:bounds context:*toImpl(contextRef) configuration:std::move(webPageConfiguration)]);

You need to update WKWebView accordingly :(
Comment 3 Simon Fraser (smfr) 2014-02-18 20:06:35 PST
WKWebView already uses the correct initializer.
Comment 4 Simon Fraser (smfr) 2014-02-18 20:07:59 PST
http://trac.webkit.org/changeset/164349