Bug 12901 - [S60] Browser ask permission for unsecure item load repeatedly
: [S60] Browser ask permission for unsecure item load repeatedly
Status: CLOSED FIXED
: WebKit
WebKit Misc.
: 523.x (Safari 3)
: PC S60 3rd edition
: P2 Normal
Assigned To:
: https://waplabdc.nokia-boston.com/bro...
: PlatformOnly
:
:
  Show dependency treegraph
 
Reported: 2007-02-26 14:28 PST by
Modified: 2011-03-21 11:53 PST (History)


Attachments
TMCN-6Y9Q7A -- TRUE - Browser ask permission for unsecure item load repeatedly (6.53 KB, patch)
2007-02-27 08:39 PST, Yinxiu Cai
yongjun.zhang: review-
Review Patch | Details | Formatted Diff | Diff
TMCN-6Y9Q7A -- TRUE - Browser ask permission for unsecure item load repeatedly (3.53 KB, patch)
2007-02-27 12:17 PST, Yinxiu Cai
yongjun.zhang: review-
Review Patch | Details | Formatted Diff | Diff
TMCN-6Y9Q7A --Browser ask permission for unsecure item load repeatedly (3.38 KB, patch)
2007-02-27 15:09 PST, Yinxiu Cai
yongjun.zhang: review+
Review Patch | Details | Formatted Diff | Diff
TMCN-6Y9Q7A --Browser ask permission for unsecure item load repeatedly For 3.1 (4.06 KB, patch)
2007-03-14 14:12 PST, Yinxiu Cai
yongjun.zhang: review+
Review Patch | Details | Formatted Diff | Diff
Fix armv5 urel build warning, so on (2.61 KB, patch)
2007-03-15 07:41 PST, Yinxiu Cai
yongjun.zhang: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2007-02-26 14:28:47 PST
Load https://waplabdc.nokia-boston.com/browser/users/tmclean/LgImage.html
Note the two "unsecure items" warnings, one for each image
It is logical to expect only one such warning when loading a page with multiple unsecure items.
------- Comment #1 From 2007-02-27 08:39:42 PST -------
Created an attachment (id=13399) [details]
TMCN-6Y9Q7A -- TRUE - Browser ask permission for unsecure item load repeatedly
------- Comment #2 From 2007-02-27 09:05:38 PST -------
Bug id 12901 is for 3.2
------- Comment #3 From 2007-02-27 09:24:47 PST -------
(From update of attachment 13399 [details])
I think the patch is incorrect:
1. maintaining iNonSecureItemShown in both CWebKitLoader and CHttpLoader is redundant.
2. add global flags in WebKitLoader for this purpose is generally not a good idea.
3. In CHttpLoader::CheckSecurityStatus, the patch only considered one senario when a secure page requests insecure subresources.  How about a insure page requests multiple secure sburesources. The ESecureItemInNonSecurePage   dialog will show up multiple times.

the patch is rejected based on abovementioned reasons.
------- Comment #4 From 2007-02-27 12:17:28 PST -------
Created an attachment (id=13406) [details]
TMCN-6Y9Q7A -- TRUE - Browser ask permission for unsecure item load repeatedly

Made change according to Yongjun's comment. Thanks a lot to Yongjun.
------- Comment #5 From 2007-02-27 14:51:45 PST -------
(From update of attachment 13406 [details])
Use the right comment in header file.
don't need to copy the result to error, just pass it right to iConfirmDialogShow should be fine.
------- Comment #6 From 2007-02-27 15:09:28 PST -------
Created an attachment (id=13413) [details]
TMCN-6Y9Q7A --Browser ask permission for unsecure item load repeatedly
------- Comment #7 From 2007-02-27 15:11:57 PST -------
(From update of attachment 13413 [details])
r=me
------- Comment #8 From 2007-02-28 14:36:13 PST -------
(In reply to comment #7)
> (From update of attachment 13413 [details] [edit])
> r=me
> 

landed on s60/trunk (r19916)

I'll assume from your earlier comment that this is not going into 3.1, so I'll set this to resolved.
------- Comment #9 From 2007-03-04 17:25:40 PST -------
Verified and Closed.
------- Comment #10 From 2007-03-14 14:12:15 PST -------
Created an attachment (id=13637) [details]
TMCN-6Y9Q7A --Browser ask permission for unsecure item load repeatedly For 3.1

12-Mar-2007 Linnalo: Valid for Maxi_0710 and S60_3_1_200710_RnD_rosetta. Could the fix be ported to 3.1 also? 
14-Mar2007 Yinxiu: So put to 3.1
------- Comment #11 From 2007-03-15 07:23:59 PST -------
(From update of attachment 13637 [details])
r = me
------- Comment #12 From 2007-03-15 07:41:00 PST -------
Created an attachment (id=13647) [details]
Fix armv5 urel build warning, so on

When put to 3.1, found armv5 urel build warning, so on. So this patch is to fix it.
------- Comment #13 From 2007-03-15 10:51:00 PST -------
(From update of attachment 13647 [details])
r=me
------- Comment #14 From 2007-03-16 11:00:27 PST -------
(In reply to comment #11)
> (From update of attachment 13637 [details] [edit])
> r = me
> 

20238
------- Comment #15 From 2007-03-16 11:16:12 PST -------
Hi Brad, Thank you for put patch 13637 to 3.1. Could you please put patch 13647 to 3.2(ccb)? thanks a lot.
------- Comment #16 From 2011-03-21 11:53:13 PST -------
re-purposing InTSW keyword for use by QtWebkit team